Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to edit merge conflict in Bitbucket #45

Closed
jmodi1982 opened this issue Oct 4, 2016 · 19 comments
Closed

Ability to edit merge conflict in Bitbucket #45

jmodi1982 opened this issue Oct 4, 2016 · 19 comments

Comments

@jmodi1982
Copy link

Hi,

Since we want to use Bitbucket for code review and merge the changes to destination branch, it is advisable to provide a capability to reviewer to edit the merge commit and checkin the code.

Without this capability the plugin does not help us in completing the code review process.

You can create a configuration option to turn this ON at repository level so that any repos not following the Bitbucket or git flow branching model can also make use of this plugin.

Thanks,
Jeemish

@mdavoodi
Copy link
Contributor

mdavoodi commented Oct 4, 2016

We still need to take a look at how much effort this would be to integrate, but I agree this would be a valuable feature.

@jmodi1982
Copy link
Author

Hi,

Any idea on when this enhancement would be done ? We have already bought this plugin for our Jira instance

@mdavoodi
Copy link
Contributor

mdavoodi commented Oct 7, 2016

We can't currently give you a specific timeline, but we're currently working on an update to be able to delete and rename files, so this would come after that.

@jmodi1982
Copy link
Author

Hi, we do not need a specific date for the fix, atleast can you give a high level estimated date (2weeks/1 month) when you might be able to do it.

1 similar comment
@jmodi1982
Copy link
Author

Hi, we do not need a specific date for the fix, atleast can you give a high level estimated date (2weeks/1 month) when you might be able to do it.

@mdavoodi
Copy link
Contributor

Unfortunately our company policy is to not publicly comment on release dates for new features. I cannot give you a specific timeline, but I can say it is currently in development.

Mohammed

@jmodi1982
Copy link
Author

Thanks Mohammed, will wait for further communication on the release

@jmodi1982
Copy link
Author

Hi Mohamed,

Any update on the issue ?

Thanks,
Jeemish

1 similar comment
@jmodi1982
Copy link
Author

Hi Mohamed,

Any update on the issue ?

Thanks,
Jeemish

@jmodi1982
Copy link
Author

Hi Mohamed,

Any update on the issue ?

Thanks,
Jeemish

@jmodi1982
Copy link
Author

Hi Mohamed,

It would be great if you can give us an update on this issue, it is becoming critical for us.

Appreciate all the help.

Thanks,
Jeemish

@jmodi1982
Copy link
Author

Hi Mohamed,

It would be great if you can give us an update on this issue, it is becoming critical for us.

Thanks,
Jeemish

@jmodi1982
Copy link
Author

@mdavoodi

Hi Mohamed,

It would be great if you can give us an update on this issue, it is becoming critical for us.

Thanks,
Jeemish

@jmodi1982
Copy link
Author

@mdavoodi

Hi Mohamed,

It is getting close to 3 months now since we opened this request. Any update on when we should expect this fixed? Without this feature, the plugin has limited use to us.

Thanks,
Jeemish

@jmodi1982
Copy link
Author

@mdavoodi

Hi Mohamed,

It is getting close to 4 months now since we opened this request. Any update on when we should expect this fixed? Without this feature, the plugin has limited use to us.

Thanks,
Jeemish

@mdavoodi
Copy link
Contributor

@jmodi1982 this has been added in version 2.6 :)

@jmodi1982
Copy link
Author

@mdavoodi The implementation of resolve conflicts is not the way which Git recommends. We wanted the ability to edit the merge commit on the destination branch and not make a new commit on source branch itself. Please can you look at the "Basic Merge Conflicts" section on the page https://git-scm.com/book/en/v2/Git-Branching-Basic-Branching-and-Merging

I would be happy to discuss over call also if you need more info.

Thanks,
Jeemish

@mdavoodi
Copy link
Contributor

I made a new issue to track your question #54. Lets move the discussion there.

@RaduTudorIon
Copy link

It's 2020, when will this be implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants