Skip to content

Commit

Permalink
fix(compiler-cli): Fix typo $implict (angular#33633)
Browse files Browse the repository at this point in the history
Should be $implicit instead.

PR Close angular#33633
  • Loading branch information
kyliau authored and mohaxspb committed Nov 7, 2019
1 parent f61f509 commit 73045a1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions packages/compiler-cli/src/diagnostics/expression_type.ts
Expand Up @@ -214,7 +214,7 @@ export class AstType implements AstVisitor {
// The members of the implicit receiver are what is defined by the
// scope passed into this class.
return {
name: '$implict',
name: '$implicit',
kind: 'component',
language: 'ng-template',
type: undefined,
Expand Down Expand Up @@ -384,7 +384,7 @@ export class AstType implements AstVisitor {
const member = receiverType.members().get(ast.name);
if (!member) {
let receiverInfo = receiverType.name;
if (receiverInfo == '$implict') {
if (receiverInfo == '$implicit') {
receiverInfo =
'The component declaration, template variable declarations, and element references do';
} else if (receiverType.nullable) {
Expand All @@ -398,7 +398,7 @@ export class AstType implements AstVisitor {
}
if (!member.public) {
let receiverInfo = receiverType.name;
if (receiverInfo == '$implict') {
if (receiverInfo == '$implicit') {
receiverInfo = 'the component';
} else {
receiverInfo = `'${receiverInfo}'`;
Expand Down Expand Up @@ -427,4 +427,4 @@ export class AstType implements AstVisitor {
return !symbol || this.query.getTypeKind(symbol) == BuiltinType.Any ||
(!!symbol.type && this.isAny(symbol.type));
}
}
}
2 changes: 1 addition & 1 deletion packages/compiler/src/expression_parser/parser.ts
Expand Up @@ -163,7 +163,7 @@ export class Parser {
'Blank expressions are not allowed in interpolated strings', input,
`at column ${this._findInterpolationErrorColumn(parts, i, interpolationConfig)} in`,
location);
expressions.push('$implict');
expressions.push('$implicit');
offsets.push(offset);
}
}
Expand Down

0 comments on commit 73045a1

Please sign in to comment.