Skip to content

fix(compiler): Fix typo $implict#33633

Closed
kyliau wants to merge 1 commit intoangular:masterfrom
kyliau:implicit
Closed

fix(compiler): Fix typo $implict#33633
kyliau wants to merge 1 commit intoangular:masterfrom
kyliau:implicit

Conversation

@kyliau
Copy link
Copy Markdown
Contributor

@kyliau kyliau commented Nov 6, 2019

Should be $implicit instead.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fix(compiler-cli): Fix typo $implict
4217317 
Should be $implicit instead.
@kyliau kyliau requested a review from a team November 6, 2019 18:35
@kyliau kyliau added the area: compiler Issues related to `ngc`, Angular's template compiler label Nov 6, 2019
@ngbot ngbot bot added this to the needsTriage milestone Nov 6, 2019
@kyliau kyliau added the target: patch This PR is targeted for the next patch release label Nov 6, 2019
@kyliau kyliau requested a review from AndrewKushnir November 6, 2019 19:28
AndrewKushnir
AndrewKushnir approved these changes Nov 6, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Nov 6, 2019
atscott pushed a commit that referenced this pull request Nov 7, 2019
@atscott
fix(compiler-cli): Fix typo $implict (#33633)
7bccef5 
Should be $implicit instead.

PR Close #33633
@atscott atscott closed this in 10583f9 Nov 7, 2019
kyliau pushed a commit to kyliau/angular that referenced this pull request Nov 7, 2019
fix(compiler-cli): Pass SourceFile to getFullText()
29eb30e 
Similar to angular#33633, this commit is
needed to fix an outage with the Angular Kythe indexer.

Crash logs:

```
TypeError: Cannot read property 'text' of undefined
    at NodeObject.getFullText (typescript/stable/lib/typescript.js:121443:57)
    at FactoryGenerator.generate (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/factory_generator.ts:67:34)
    at GeneratedShimsHostWrapper.getSourceFile (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/host.ts:88:26)
    at findSourceFile (typescript/stable/lib/typescript.js:90654:29)
    at typescript/stable/lib/typescript.js:90553:85
    at getSourceFileFromReferenceWorker (typescript/stable/lib/typescript.js:90520:34)
    at processSourceFile (typescript/stable/lib/typescript.js:90553:13)
    at processRootFile (typescript/stable/lib/typescript.js:90383:13)
    at typescript/stable/lib/typescript.js:89399:60
    at Object.forEach (typescript/stable/lib/typescript.js:280:30)

```
@kyliau kyliau mentioned this pull request Nov 7, 2019
Closed
14 tasks
kara pushed a commit that referenced this pull request Nov 8, 2019
@kara
fix(compiler-cli): Pass SourceFile to getFullText() (#33660)
a33162b 
Similar to #33633, this commit is
needed to fix an outage with the Angular Kythe indexer.

Crash logs:

```
TypeError: Cannot read property 'text' of undefined
    at NodeObject.getFullText (typescript/stable/lib/typescript.js:121443:57)
    at FactoryGenerator.generate (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/factory_generator.ts:67:34)
    at GeneratedShimsHostWrapper.getSourceFile (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/host.ts:88:26)
    at findSourceFile (typescript/stable/lib/typescript.js:90654:29)
    at typescript/stable/lib/typescript.js:90553:85
    at getSourceFileFromReferenceWorker (typescript/stable/lib/typescript.js:90520:34)
    at processSourceFile (typescript/stable/lib/typescript.js:90553:13)
    at processRootFile (typescript/stable/lib/typescript.js:90383:13)
    at typescript/stable/lib/typescript.js:89399:60
    at Object.forEach (typescript/stable/lib/typescript.js:280:30)

```

PR Close #33660
kara pushed a commit that referenced this pull request Nov 8, 2019
@kara
fix(compiler-cli): Pass SourceFile to getFullText() (#33660)
33f6cd4 
Similar to #33633, this commit is
needed to fix an outage with the Angular Kythe indexer.

Crash logs:

```
TypeError: Cannot read property 'text' of undefined
    at NodeObject.getFullText (typescript/stable/lib/typescript.js:121443:57)
    at FactoryGenerator.generate (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/factory_generator.ts:67:34)
    at GeneratedShimsHostWrapper.getSourceFile (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/host.ts:88:26)
    at findSourceFile (typescript/stable/lib/typescript.js:90654:29)
    at typescript/stable/lib/typescript.js:90553:85
    at getSourceFileFromReferenceWorker (typescript/stable/lib/typescript.js:90520:34)
    at processSourceFile (typescript/stable/lib/typescript.js:90553:13)
    at processRootFile (typescript/stable/lib/typescript.js:90383:13)
    at typescript/stable/lib/typescript.js:89399:60
    at Object.forEach (typescript/stable/lib/typescript.js:280:30)

```

PR Close #33660
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Dec 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 8, 2019
@kyliau kyliau deleted the implicit branch December 17, 2019 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

3 participants

@kyliau @AndrewKushnir @googlebot