Skip to content

/angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Fix typo $implict #33633

Closed
wants to merge 1 commit into from
+5 −5

Conversation

@kyliau
Copy link
Member

kyliau commented Nov 6, 2019

Should be $implicit instead.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information
@kyliau
fix(compiler-cli): Fix typo $implict
Loading status checks…
4217317 
Should be $implicit instead.
@kyliau kyliau requested a review from angular/fw-compiler as a code owner Nov 6, 2019
@googlebot googlebot added the cla: yes label Nov 6, 2019
@ngbot ngbot bot added this to the needsTriage milestone Nov 6, 2019
@kyliau kyliau requested a review from AndrewKushnir Nov 6, 2019
@AndrewKushnir
AndrewKushnir approved these changes Nov 6, 2019
View changes
Copy link
Contributor

AndrewKushnir left a comment

LGTM 👍
atscott added a commit that referenced this pull request Nov 7, 2019
@kyliau @atscott
fix(compiler-cli): Fix typo $implict (#33633)
Loading status checks…
7bccef5 
Should be $implicit instead.

PR Close #33633
@atscott atscott closed this in 10583f9 Nov 7, 2019
mohaxspb added a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
@kyliau @mohaxspb
fix(compiler-cli): Fix typo $implict (angular#33633)
8306c7b 
Should be $implicit instead.

PR Close angular#33633
mohaxspb added a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
@kyliau @mohaxspb
fix(compiler-cli): Fix typo $implict (angular#33633)
73045a1 
Should be $implicit instead.

PR Close angular#33633
kyliau added a commit to kyliau/angular that referenced this pull request Nov 7, 2019
@kyliau
fix(compiler-cli): Pass SourceFile to getFullText()
29eb30e 
Similar to angular#33633, this commit is
needed to fix an outage with the Angular Kythe indexer.

Crash logs:

```
TypeError: Cannot read property 'text' of undefined
    at NodeObject.getFullText (typescript/stable/lib/typescript.js:121443:57)
    at FactoryGenerator.generate (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/factory_generator.ts:67:34)
    at GeneratedShimsHostWrapper.getSourceFile (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/host.ts:88:26)
    at findSourceFile (typescript/stable/lib/typescript.js:90654:29)
    at typescript/stable/lib/typescript.js:90553:85
    at getSourceFileFromReferenceWorker (typescript/stable/lib/typescript.js:90520:34)
    at processSourceFile (typescript/stable/lib/typescript.js:90553:13)
    at processRootFile (typescript/stable/lib/typescript.js:90383:13)
    at typescript/stable/lib/typescript.js:89399:60
    at Object.forEach (typescript/stable/lib/typescript.js:280:30)

```
@kyliau kyliau mentioned this pull request Nov 7, 2019
Closed
2 of 14 tasks complete
kara added a commit that referenced this pull request Nov 8, 2019
@kyliau @kara
fix(compiler-cli): Pass SourceFile to getFullText() (#33660)
Loading status checks…
a33162b 
Similar to #33633, this commit is
needed to fix an outage with the Angular Kythe indexer.

Crash logs:

```
TypeError: Cannot read property 'text' of undefined
    at NodeObject.getFullText (typescript/stable/lib/typescript.js:121443:57)
    at FactoryGenerator.generate (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/factory_generator.ts:67:34)
    at GeneratedShimsHostWrapper.getSourceFile (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/host.ts:88:26)
    at findSourceFile (typescript/stable/lib/typescript.js:90654:29)
    at typescript/stable/lib/typescript.js:90553:85
    at getSourceFileFromReferenceWorker (typescript/stable/lib/typescript.js:90520:34)
    at processSourceFile (typescript/stable/lib/typescript.js:90553:13)
    at processRootFile (typescript/stable/lib/typescript.js:90383:13)
    at typescript/stable/lib/typescript.js:89399:60
    at Object.forEach (typescript/stable/lib/typescript.js:280:30)

```

PR Close #33660
kara added a commit that referenced this pull request Nov 8, 2019
@kyliau @kara
fix(compiler-cli): Pass SourceFile to getFullText() (#33660)
Loading status checks…
33f6cd4 
Similar to #33633, this commit is
needed to fix an outage with the Angular Kythe indexer.

Crash logs:

```
TypeError: Cannot read property 'text' of undefined
    at NodeObject.getFullText (typescript/stable/lib/typescript.js:121443:57)
    at FactoryGenerator.generate (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/factory_generator.ts:67:34)
    at GeneratedShimsHostWrapper.getSourceFile (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/host.ts:88:26)
    at findSourceFile (typescript/stable/lib/typescript.js:90654:29)
    at typescript/stable/lib/typescript.js:90553:85
    at getSourceFileFromReferenceWorker (typescript/stable/lib/typescript.js:90520:34)
    at processSourceFile (typescript/stable/lib/typescript.js:90553:13)
    at processRootFile (typescript/stable/lib/typescript.js:90383:13)
    at typescript/stable/lib/typescript.js:89399:60
    at Object.forEach (typescript/stable/lib/typescript.js:280:30)

```

PR Close #33660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewKushnir AndrewKushnir

Assignees
No one assigned
Labels
PR action: merge PR target: master & patch cla: yes comp: compiler
Projects
None yet
Milestone
  needsTriage
3 participants
@kyliau @AndrewKushnir @googlebot
You can’t perform that action at this time.