Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force =true with obj.id != 0 in insert now use the given id #174

Merged
merged 7 commits into from
Sep 14, 2022

Conversation

Clonkk
Copy link
Contributor

@Clonkk Clonkk commented Sep 12, 2022

This PR solves #173

@Clonkk
Copy link
Contributor Author

Clonkk commented Sep 12, 2022

@moigagoo I used conflictPolicy & unified the behavior between SQLite & Postgres regarding manually inserted ids.

…overriding id (which would trigger every time after ONE manual insertion); this required adding llexec.nim for low level control of pgsql result expectation
@moigagoo
Copy link
Owner

@moigagoo I used conflictPolicy & unified the behavior between SQLite & Postgres regarding manually inserted ids.

@Clonkk I think the reason I only implemented this feature for SQLite initially is that Postgres didn't have this at all.

Apparently, this works now as the tests pass, so I'm happy to merge this.

Thanks!

@moigagoo moigagoo merged commit 53a93ae into moigagoo:develop Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants