Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process last-checks that do not have any metrics stored #166

Closed
borovskyav opened this issue Dec 28, 2018 · 1 comment
Closed

Process last-checks that do not have any metrics stored #166

borovskyav opened this issue Dec 28, 2018 · 1 comment
Assignees
@borovskyav
Labels
backend bug
Projects
2.5

Comments

@borovskyav
Copy link
Contributor

При удалении last check'а мы удаляем все метрики по паттернам триггера. После этого, если по оставшимся каким-то из last check'ов больше не приходят метрики, то у этих last check'ов больше не будет происходить поверка и никогда не поменяется состояние.

Как это сказывается на пользователе:

  1. Мы никогда больше не отравим по таким метрикам эвент, о том что метрика в NODATA
  2. Мы не удалим такие метрики автоматически, если триггер имеет NODATA state == DEL
  3. Мы никогда не уберем последнее значение метрики, если оно не было равно NIL

Как решать проблему:
Если после получения метрик мы понимаем, что у нас есть какие-то last check'и по которым нет метрик, сделать на них checkForNoData
@borovskyav borovskyav created this issue from a note in 2.5 (Ready to develop) Dec 28, 2018
@borovskyav borovskyav mentioned this issue Dec 28, 2018
Open
3 tasks
@borovskyav borovskyav added the bug label Dec 28, 2018
@beevee beevee changed the title Обработка last check'ов по которым нет метрик Process last-checks that do not have any metrics stored Dec 29, 2018
@borovskyav borovskyav moved this from Ready to develop to In progress in 2.5 Jan 26, 2019
@borovskyav borovskyav self-assigned this Jan 26, 2019
@borovskyav borovskyav mentioned this issue Jan 27, 2019
Merged
borovskyav added a commit that referenced this issue Feb 3, 2019
@borovskyav
Process last-checks that do not have any metrics stored. Fix #166 (#224)
62d715f 
* Small code extrations from handleMetricsCheck method

* Update goconvey and all deps

* Get MetricsData to check and check it on duplicates in separate function

* Process last-checks that do not have any metrics stored

* Fix lint

* dont wtite message in mail_test

* Add  tests, fix bugs

* Add agregate flat to gometalinter

* Refactor: make TriggerChecker fields private

* Refactor MakeTriggerChecker func.

* Refactor: rename timeseries vars to metric, small cleanup and code moves

* Refactor: simplify trigger_checker functions
2.5 automation moved this from In progress to Done Feb 3, 2019
@borovskyav
Copy link
Contributor Author

Заодно пофиксил проблему с тем что мы не чекали триггер, если нам по каким-то причинам не возвращались метрики #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@borovskyav borovskyav

Labels
backend bug
Projects
No open projects
2.5
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@borovskyav