Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process last-checks that do not have any metrics stored. Fix #166 #224

Merged
merged 12 commits into from
Feb 3, 2019

Conversation

borovskyav
Copy link
Contributor

@borovskyav borovskyav commented Jan 27, 2019

Fix #166
Чет я в ветке вообще разошелся, поясняю за коммиты:

  • 10fe58a, 878d9f3 - рефакторинг перед задачей, чтобы было не больно править баг.
  • fcaf6ad, 579a0b5, dac6230 - правка, самого бага. Из за того что поделал рефакторинг все втащилось в несколько строчек.
  • 3e4317c - обновил GoConvey
  • Все остальное - удовлетворял своего перфекциониста, рефакторил код, в итоге получилось мило, хотя изменений чет много из за ренеймов. Немного порефакторил MakeTriggerChecker. Код стал значительно чище.

@borovskyav borovskyav changed the title Process last-checks that do not have any metrics stored Process last-checks that do not have any metrics stored. Fix #166 Jan 27, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 84.034% when pulling 966ee05 on feature/handle-nometrics-lastchecks into 30fabf5 on develop.

@borovskyav borovskyav merged commit 62d715f into develop Feb 3, 2019
@borovskyav borovskyav deleted the feature/handle-nometrics-lastchecks branch February 3, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants