New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fake API refactoring #304
Comments
I want to work on it. |
@Vivekrajput20 please give chance to others :-) But if someone will not take it in few days, of course, you can |
@sashasushko Can I take this up? |
@shiv6146 yep, you can try ;-) |
@shiv6146 how you'r going? |
@sashasushko May I take up this task? I think it has already been many days. |
Thank you |
@alekhyaNynala Hi. |
@sashasushko Ok I'll work on this one. |
@alekhyaNynala thank you, not me :-) |
@sashasushko just want some clarifications before i start working on this issue. Can values be any random string or it should have some optimal substructure ? Like |
Hi @hv7214, |
@sashasushko I think I could do this enhancement. Is this still available for assignment? |
@kunaltawatia i know that it has to be string, that's why asked for clarification regarding the structure. Any random string doesn't make much sense. I think you should have a look in |
Oh I might have got your question wrong. |
@kunaltawatia is right. The type must be correct. It's "first of all". But @hv7214 your opinion about consistency of mock data also is correct. I'm not familiar with target syntax, you can dig itself (there is some page in documentation) or ask backend developers. For example, @beevee |
For easy development we use fake API server (look
fakeapi
folder). But we keep all data in one bigdb.json
file. It's not comfortable. json-server tool allow generate data on the go by JavaScript (look Generate random data).ToDo
Domain
folder, not on data fromdb.json
file. Data in file could be obsoletedb.json
Warn!
We don't have any tests yet, so to check that the backward compatibility is not broken, you will have to check everything by your hands. If you find it easier, you can instead write unit tests for
MoiraApi.js
. There is Jest in project. Installed and configured.Please, look at two our major rules for contributors.
The text was updated successfully, but these errors were encountered: