Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fakeapi/random data population #303

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kunaltawatia
Copy link
Contributor

Details

  • Fake API server is now provided with randomly generated data from fakeapi/index.js
  • removed obsolete fakeapi/db.json file
  • Additional dependency: Chancejs, license: MIT, to create random data, as suggested in the generate random data block in json-server's documentation
  • Also paths like /tags, /patterns are now available to view.

Tests
Manual testing is done. Backward compatibility is by far observed to be intact.

fakeAPI_ pull request1


chrome-capture2 (1)


chrome-capture (3)


chrome-capture (4)


chrome-capture (2)

Issues
moira-alert/moira#304

@sashasushko
Copy link

@kunaltawatia thank you for good job! I need some time to review and test your PR

@beevee beevee requested a review from a team March 12, 2020 07:29
@beevee beevee added the feature label Mar 12, 2020
@beevee beevee added this to Review in 2.6 via automation Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
2.6
  
Review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants