Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated method of prometheus #809

Closed
Dimedrolity opened this issue Dec 2, 2022 · 0 comments · Fixed by #832
Closed

Replace deprecated method of prometheus #809

Dimedrolity opened this issue Dec 2, 2022 · 0 comments · Fixed by #832

Comments

@Dimedrolity
Copy link
Contributor

Overview

Moira uses prometheus pkg

Problem

Linter error

metrics\prometheus.go:15:24: SA1019: prometheus.NewGoCollector is deprecated: Use collectors.NewGoCollector instead. (staticcheck)
        registry.MustRegister(prometheus.NewGoCollector(), prometheus.NewProcessCollector(prometheus.ProcessCollectorOpts{}))

Solution

Replace deprecated methods that linter suggests and check that all works as before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants