Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prometheus version and change deprecated methods #832

Conversation

kissken
Copy link
Member

@kissken kissken commented Feb 20, 2023

Additional information

Closes/Relates #809

@kissken kissken requested a review from a team as a code owner February 20, 2023 07:43
@codecov-commenter
Copy link

Codecov Report

Merging #832 (9f1c13e) into feature/add_metric_for_build_plots (9c8ef99) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

❗ Current head 9f1c13e differs from pull request most recent head 5851eb9. Consider uploading reports for the commit 5851eb9 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                          Coverage Diff                           @@
##           feature/add_metric_for_build_plots     #832      +/-   ##
======================================================================
- Coverage                               70.44%   70.41%   -0.03%     
======================================================================
  Files                                     179      179              
  Lines                                    9750     9754       +4     
======================================================================
  Hits                                     6868     6868              
- Misses                                   2494     2498       +4     
  Partials                                  388      388              
Impacted Files Coverage Δ
notifier/plotting.go 57.65% <20.00%> (-2.16%) ⬇️
notifier/scheduler.go 84.25% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kissken kissken force-pushed the feature/update_prometheus_client_and_remove_deprecations branch from de48b54 to 94cc8ae Compare February 20, 2023 07:53
@kissken kissken linked an issue Feb 20, 2023 that may be closed by this pull request
@kissken kissken self-assigned this Feb 20, 2023
@kissken kissken changed the base branch from feature/add_metric_for_build_plots to feature/update_go_mod February 20, 2023 10:48
@kissken kissken merged commit e49573b into feature/update_go_mod Feb 21, 2023
@kissken kissken deleted the feature/update_prometheus_client_and_remove_deprecations branch February 21, 2023 06:44
@kissken kissken mentioned this pull request Feb 21, 2023
kissken added a commit that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated method of prometheus
3 participants