-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added profiling #48
added profiling #48
Conversation
cmd/filter/config.go
Outdated
@@ -36,5 +37,8 @@ func getDefault() config { | |||
Prefix: "DevOps.Moira", | |||
Interval: "60s0ms", | |||
}, | |||
Pprof: cmd.ProfilerConfig{ | |||
Port: "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Давай, сделаем Listen. Во первых чтобы было единообразие с api, во вторых потому что там не порт на самом деле а ":8888"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Исправил
cmd/config.go
Outdated
@@ -52,6 +52,11 @@ type LoggerConfig struct { | |||
LogLevel string `yaml:"log_level"` | |||
} | |||
|
|||
// ProfilerConfig is pprof settings, which are taken on the start of moira | |||
type ProfilerConfig struct { | |||
Port string `yaml:"port"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ну и понятно, здесь тоже хочется видеть Listen string yaml:"listen"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Исправил
No description provided.