added profiling #48
Merged
added profiling #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borovskyav
reviewed
Dec 5, 2017
cmd/filter/config.go
Outdated
| @@ -36,5 +37,8 @@ func getDefault() config { | |||
| Prefix: "DevOps.Moira", | |||
| Interval: "60s0ms", | |||
| }, | |||
| Pprof: cmd.ProfilerConfig{ | |||
| Port: "", | |||
There was a problem hiding this comment.
Давай, сделаем Listen. Во первых чтобы было единообразие с api, во вторых потому что там не порт на самом деле а ":8888"
cmd/config.go
Outdated
| @@ -52,6 +52,11 @@ type LoggerConfig struct { | |||
| LogLevel string `yaml:"log_level"` | |||
| } | |||
|
|
|||
| // ProfilerConfig is pprof settings, which are taken on the start of moira | |||
| type ProfilerConfig struct { | |||
| Port string `yaml:"port"` | |||
There was a problem hiding this comment.
Ну и понятно, здесь тоже хочется видеть Listen string yaml:"listen"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.