Fix checker bugs #621
Merged
Fix checker bugs #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litleleprikon
changed the title
litleleprikon
force-pushed
the
feature/fix-checker-bugs
branch
from
ec93f57
to
06786e2
Compare
litleleprikon
force-pushed
the
feature/fix-checker-bugs
branch
from
06786e2
to
2d3e59f
Compare
litleleprikon
force-pushed
the
feature/fix-checker-bugs
branch
2 times, most recently
from
cd4b130
to
bee3ba8
Compare
litleleprikon
force-pushed
the
feature/fix-checker-bugs
branch
from
0b18913
to
bc02d1e
Compare
litleleprikon
force-pushed
the
feature/fix-checker-bugs
branch
from
bc02d1e
to
cecab4b
Compare
Codecov Report
@@ Coverage Diff @@
## master #621 +/- ##
=========================================
Coverage ? 69.36%
=========================================
Files ? 172
Lines ? 7668
Branches ? 0
=========================================
Hits ? 5319
Misses ? 2014
Partials ? 335 Continue to review full report at Codecov.
|
litleleprikon
force-pushed
the
feature/fix-checker-bugs
branch
from
f29b69f
to
71fbc24
Compare
If trigger is simple we can enable realtime alerting for it. This means that for each new metric we will check that trigger with new metric. Simple trigger means that this trigger have only one metric. This is able only if trigger have target without wildcards and braces. With support for metrics with tags we need to add a new condition for simple trigger% it should not use metrics with tags. In this commit we rewrite simple trigger check.
Fix handling of alone metrics. Change behavior of alone targets population. Before the behavior were the same for alone metrics targets and regular targets. This led to situations when alone metrics occurred in regular targets that should not happen. Npw alone metrics are populated in different way than regular metrics. Relates #428
When appear unrecognized error checker is just write warning to log and do not mark trigger with exception state. This behavior is changed to mark trigger with exception state.
litleleprikon
force-pushed
the
feature/fix-checker-bugs
branch
2 times, most recently
from
43c0054
to
16b8205
Compare
litleleprikon
force-pushed
the
feature/fix-checker-bugs
branch
from
16b8205
to
e53e606
Compare
borovskyav
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes known bugs in checker that appeared during implementation of improved advanced mode
Relates #428