Extended list of broken contact errors #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryanchikov
force-pushed
the
refactor/broken-contact-error-extension
branch
4 times, most recently
from
574c980
to
aeda94a
Compare
KiskachiMaria
previously approved these changes
Feb 11, 2022
zhelyabuzhsky
suggested changes
Feb 15, 2022
|
|
||
| func TestCheckBrokenContactError(t *testing.T) { | ||
| logger, _ := logging.ConfigureLog("stdout", "debug", "test", true) | ||
| Convey("Check broken contact error", t, func() { |
There was a problem hiding this comment.
Suggested change
| Convey("Check broken contact error", t, func() { | |
| Convey("During checking broken contact error", t, func() { |
There was a problem hiding this comment.
I like original wording more, I feel it's more correct. How big is the value in difference with your proposed phrase? :)
There was a problem hiding this comment.
I wanted to follow the test framework author's examples, but if you want to leave it like that, then ok :)
dmitryanchikov
force-pushed
the
refactor/broken-contact-error-extension
branch
from
aeda94a
to
7a7bcb7
Compare
zhelyabuzhsky
previously approved these changes
Feb 21, 2022
KiskachiMaria
previously approved these changes
Feb 21, 2022
dmitryanchikov
dismissed stale reviews from KiskachiMaria and zhelyabuzhsky
via
7c364b9
dmitryanchikov
force-pushed
the
refactor/broken-contact-error-extension
branch
from
7a7bcb7
to
7c364b9
Compare
dmitryanchikov
force-pushed
the
refactor/broken-contact-error-extension
branch
from
7c364b9
to
83bded8
Compare
KiskachiMaria
approved these changes
Mar 9, 2022
zhelyabuzhsky
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended list of broken contact errors in telegram notifier sender
Broken contact errors are basically kind of rare user scenarious treated separately. Particularly they aren't resent and they are just warnings in logs. This PR extends that list with couple of telegram-specific scenarious:
ErrNoRightsToSendPhoto,ErrNoRightsToSend)ErrChatNotFound)