Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty string check as metric name can be blank. #77

Merged
merged 1 commit into from
May 7, 2018
Merged

Remove empty string check as metric name can be blank. #77

merged 1 commit into from
May 7, 2018

Conversation

titusjaka
Copy link
Contributor

Sometimes metric name can be blank, so empty string check is redundant.

Moira doesn't have to throw error when metric name is empty.

firefox_2018-04-16_17-08-14

@titusjaka titusjaka added the bug label Apr 16, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.162% when pulling 83d54d0 on empty-metric into 627df0a on master.

@titusjaka
Copy link
Contributor Author

Checked on Staging. Everything is 👌

@titusjaka titusjaka merged commit 2167422 into master May 7, 2018
@titusjaka titusjaka deleted the empty-metric branch May 7, 2018 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borovskyav borovskyav borovskyav approved these changes

Assignees

@borovskyav borovskyav

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@titusjaka @coveralls @borovskyav