Fixing logger terminal error

[matt-heery]

This is a fix to the issue that occurs when running a script with this module imported:

Before:

If you imported this module, it would change the root logger, and how it formatted logs, including a context element in the message. Since the module wants to send a log file to a specific file it created two handlers, one for the console and one for the log file, with differing levels (amongst other changes). The context filter (which creates default context for any logger message that doesnt have one from root upwards) wasn't added two both handlers and just added to the logger (using logger.addFilter()). This lead to hundreds of logging errors where the console handler couldn't find context. This made the logs literally impossible to read in terminal and made development very difficult.

After:

I have looped through all handlers and have added the filter specifically to each handler. This was a fix I had to implement in the airflow-matrix-scraper repo by editing the root handler and doing the exact same thing, so hoping fix will carry over to here.

[Thomas-Hirsch]

great stuff with the detailed request message!

I think this is ok to me, though there may be an issue with using the root logger specifically as it could interact with other packages. Could use some further testing, and may end up changing it so it doesn't ask for the root logger.

If you bump the version (in both pyproject.yaml and data_linter.init.py) and update the changelog, I'd be happy to approve as is

[matt-heery]

yeah igy re the root logger - though i dont think this should change any of the other packages logs, just standardise them log shown in terminal to be the same as the one in the log file - havent tested loads so agree, and made the changes requested

[Thomas-Hirsch]

Approved, only like 2 months late...