Docs workflow - build and check links on PRs #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADBond
added
documentation
RossKen
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Closes #1914, as mooted in this comment.
Give a brief description for the solution you have provided
In documentation workflow splits
deployjob intobuild(which also checks links) anddeployjobs.Workflow runs on pushes to master (as before), and on PRs into master (in which case
deploydoes not run). PR version only runs if relevant files have changed.See examples of the PR version (with no deploy) in this PR - versions which pass and fail link checking. Here is a run coming from 'push' (that includes the
deployjob running).PR Checklist