Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate accuracy 2 #2187

Merged
merged 7 commits into from
May 17, 2024
Merged

Consolidate accuracy 2 #2187

merged 7 commits into from
May 17, 2024

Conversation

RobinL
Copy link
Member

@RobinL RobinL commented May 17, 2024

Supersedes #2147

Consolidates

truth_space_table_from_labels_{type}
roc_chart_from_labels_{type}
precision_recall_chart_from_labels_{type}
accuracy_chart_from_labels_{type}
threshold_selection_tool_from_labels_{type}

to

accuracy_analysis_from_labels_{type}

Where {type} is either 'table' or 'column

Questions:

  • Should truth_space_table_from_labels_ be a separate function, since its return type is different?
  • Should we bother retaining the precision_recall and roc options?

Closes #2010

@RobinL RobinL merged commit fb8272b into splink4_dev May 17, 2024
24 of 25 checks passed
@RobinL RobinL deleted the consolidate_accuracy_2 branch May 17, 2024 13:53
@ADBond ADBond mentioned this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant