Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Documentation for GCBM REST API #144

Merged
merged 11 commits into from
Oct 16, 2022

Conversation

Saurabh-Suchak
Copy link
Contributor

Pull Request Template

Description

Since a new GCBM run has been developed, this PR contains a new readme file containing the steps to run GCBM simulation locally.

Fixes the old documentation with updated instructions.

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

The steps provided in the readme are executed are multiple times and verified.

aornugent
aornugent previously approved these changes Jul 10, 2022

1. Create a new simulation (the default title of the simulation is `simulation`, here the title `run4` is used):
```
curl -d "title=run4" -X POST http://localhost:8080/gcbm/new
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title can be anything eg. "example-run"

@padmajabhol
Copy link
Member

Hey @Saurabh-Suchak is it possible for you to change the PR to a meaningful name? "Documentation for GCBM REST API" or something on that line?

Copy link
Member

@padmajabhol padmajabhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Namyalg had worked on the the endpoint that lets us change the table schema for the data base.
Please refer to https://github.com/Namyalg/gcbm-table-schema to understand how it works and we can interact with the endpoint. I'm sure we need it to go along with the entire documentation.

@Saurabh-Suchak Saurabh-Suchak changed the title Readme Updated Documentation for GCBM REST API Jul 13, 2022
@Saurabh-Suchak
Copy link
Contributor Author

@Namyalg had worked on the the endpoint that lets us change the table schema for the data base. Please refer to https://github.com/Namyalg/gcbm-table-schema to understand how it works and we can interact with the endpoint. I'm sure we need it to go along with the entire documentation.

Sure, I will update the documentation as per the requirement

@HarshCasper HarshCasper merged commit 00c9b96 into moja-global:master Oct 16, 2022
Freeman-kuch pushed a commit to Freeman-kuch/FLINT.Cloud that referenced this pull request Oct 20, 2022
* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* changed the endpoint name

* Update app.py

* Update README.md

Co-authored-by: Harsh Mishra <erbeusgriffincasper@gmail.com>
Signed-off-by: Freeman <freemanoparaocha@gmail.com>
Freeman-kuch pushed a commit to Freeman-kuch/FLINT.Cloud that referenced this pull request Oct 20, 2022
* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* changed the endpoint name

* Update app.py

* Update README.md

Co-authored-by: Harsh Mishra <erbeusgriffincasper@gmail.com>
Signed-off-by: Freeman <freemanoparaocha@gmail.com>
Freeman-kuch pushed a commit to Freeman-kuch/FLINT.Cloud that referenced this pull request Oct 20, 2022
* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* changed the endpoint name

* Update app.py

* Update README.md

Co-authored-by: Harsh Mishra <erbeusgriffincasper@gmail.com>
Signed-off-by: Freeman <freemanoparaocha@gmail.com>
Freeman-kuch pushed a commit to Freeman-kuch/FLINT.Cloud that referenced this pull request Oct 27, 2022
* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* changed the endpoint name

* Update app.py

* Update README.md

Co-authored-by: Harsh Mishra <erbeusgriffincasper@gmail.com>
Signed-off-by: Freeman <freemanoparaocha@gmail.com>
Freeman-kuch pushed a commit to Freeman-kuch/FLINT.Cloud that referenced this pull request Oct 28, 2022
* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* changed the endpoint name

* Update app.py

* Update README.md

Co-authored-by: Harsh Mishra <erbeusgriffincasper@gmail.com>
Signed-off-by: Freeman <freemanoparaocha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants