Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to support non-S3 configuration #28

Merged
merged 2 commits into from Jul 31, 2021

Conversation

nynaalekhya
Copy link
Contributor

@nynaalekhya nynaalekhya commented Jul 18, 2021

Description

Supports non-S3 configuration

Fixes # (issue)
Fixes #8

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Steps documented in rest_local_run/README.md

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

…a <nynalaalekhya@gmail.com>

Signed-off-by: nynalaalekhya <nynalaalekhya@gmail.com>
…a <nynalaalekhya@gmail.com>

Signed-off-by: nynalaalekhya <nynalaalekhya@gmail.com>
Copy link
Contributor

@aornugent aornugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nynaalekhya - these changes look great! Please merge when you're ready.

@shubhamkarande13 was able to run your Postman collection successfully - Shubham, please file an issue if there were any supporting instructions that you thought were helpful.

@shubhamkarande13 shubhamkarande13 merged commit 0d58faa into moja-global:master Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fall back for non-S3 configuration
3 participants