Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrcture for PyPI and update documentation #31

Merged
merged 5 commits into from
Aug 23, 2020

Conversation

abhineet97
Copy link
Collaborator

@abhineet97 abhineet97 commented Aug 22, 2020

Description

It seems that the Rasterio wheels that are available of PyPI do not support ZSTD. Sadly, without that, it would not make sense to publish Taswira on PyPI, so we'll have to hold that for now. Anyways, I've restructured the project and have added all the necessary files required to publish the package on PyPI. I've done this to make sure that in the future when Rasterio adds support for ZSTD in its PyPI wheel, we'll be able to quickly publish Taswira.

Apart from that I've also updated the README with all the necessary usage information (along with some shiny badges and a screenshot). Let me know if it needs more improvement.

Fixes #30

How Has This Been Tested?

Using unit-tests and manual tests

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

The Python package `taswira` has now been moved to the root of the
repository.

The continous integration GitHub Action has also been update
accordingly.

Signed-off-by: Abhineet Tamrakar <abhineet97@gmail.com>
This structure has many benifits as outlined here
https://blog.ionelmc.ro/2014/05/25/python-packaging/#the-structure

Signed-off-by: Abhineet Tamrakar <abhineet97@gmail.com>
This commit adds all the necessary files so that the module can be
uploaded to PyPI.

Due to limitations in flit, I've decided to remove it and adopt the
traditional setuptools based approach instead.

Signed-off-by: Abhineet Tamrakar <abhineet97@gmail.com>
Signed-off-by: Abhineet Tamrakar <abhineet97@gmail.com>
Signed-off-by: Abhineet Tamrakar <abhineet97@gmail.com>
@abhineet97 abhineet97 requested a review from kaskou August 22, 2020 08:24
@kaskou kaskou merged commit 3ea2591 into moja-global:master Aug 23, 2020
@abhineet97 abhineet97 mentioned this pull request Aug 27, 2020
21 tasks
@abhineet97 abhineet97 added the gsoc2020 Created as part of a Google Summer of Code 2020 project. label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc2020 Created as part of a Google Summer of Code 2020 project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure and Publish CLI on PyPI using Flit
2 participants