Intro to storybook setup #55
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @Palaksharma23 @Janvi-Thakkar kindly review and let me know if any change is required. I have tried to make stuff as detailed as possible, but I'm open to your suggestions. |
Signed-off-by: Abhilipsa Sahoo <abhilipsasahoo03@gmail.com>
abhilipsasahoo03
force-pushed
the
intro-to-storybook-setup
branch
from
a16b4cf
to
53d60f9
Compare
|
Hi @Palaksharma23 @Janvi-Thakkar @padmajabhol please take a look. |
|
Hi @Palaksharma23 @Janvi-Thakkar kindly review and let me know if any change is required :) |
|
@Palaksharma23 @Janvi-Thakkar @padmajabhol kindly review! |
|
Hi @chicken-biryani could you please take a look? |
|
Hey @abhilipsasahoo03 yes |
There was a problem hiding this comment.
Lgtm.
@Janvi-Thakkar @Palaksharma23 @padmajabhol will you please have a look?
|
@abhilipsasahoo03 I am sorry that we didn't review it in time. Please feel free to put up the link for review on slack for PR reviews. |
Sure! It's okay! I'll do that next time onwards! |
There was a problem hiding this comment.
Hi @abhilipsasahoo03. Awesome work on this part! I've left some suggestions. Take a look at them. LGTM otherwise! :)
Thanks for the suggestions @Crystalsage I'll work on them asap! :) |
|
Hi @abhilipsasahoo03, Thanks for working on this. Apologies for not reviewing your PR for so long. Will try not toi repeat this but incase we take time in future, please ping on slack. |
It's okay :) no issues! |
|
@abhilipsasahoo03 Please consider doing changes which Amit and I suggested. We might do detailed review again once it's done! I would like to know your thoughts or doubts for any suggestions. Please feel free to tag or ping us. |
|
Very nice work and effort @abhilipsasahoo03 ❤. This PR has been on my mind for a long time, but it kept getting delayed. |
@Palaksharma23 @Janvi-Thakkar It's okay! I'll work on the provided suggestions asap and let you know! :) |
|
@Palaksharma23 @Janvi-Thakkar @Crystalsage I've made some changes according to your suggestions. Kindly review. :) |
| <img src="/moja-global-icon.jpg" alt="logo" height="225" width="390"/> | ||
| </center> | ||
|
|
||
| # |
There was a problem hiding this comment.
This is to add a slight gap between the image and the title, since I was unable to do so in any other way. Let me know if there's any replacement to that?
| cd mojaglobal-ui | ||
| mkdir component_name | ||
| cd component_name | ||
| ``` |
There was a problem hiding this comment.
Either remove space above sh or add space below (before 2nd point).
There was a problem hiding this comment.
I think this is yet to be done.
There was a problem hiding this comment.
Also adding space looks better option.
There was a problem hiding this comment.
@Janvi-Thakkar I have already made that change I suppose
It probably isn't reflecting in the storybook?
There was a problem hiding this comment.
yes, it's not reflecting in storybook
Signed-off-by: Abhilipsa Sahoo <abhilipsasahoo03@gmail.com>
Signed-off-by: Abhilipsa Sahoo <abhilipsasahoo03@gmail.com>
Signed-off-by: Abhilipsa Sahoo <abhilipsasahoo03@gmail.com>
|
@HarshCasper @Janvi-Thakkar @Palaksharma23 I've made some changes, kindly review! |
|
@abhilipsasahoo03, Thanks for working on suggestions. At some places the tarnsition of moja global —> Moja global is not yet done. Please consider changing it at all places for uniformity. |
Signed-off-by: Abhilipsa Sahoo <abhilipsasahoo03@gmail.com>
Signed-off-by: Abhilipsa Sahoo <abhilipsasahoo03@gmail.com>
Sorry for that. Done! |
Signed-off-by: Abhilipsa Sahoo <abhilipsasahoo03@gmail.com>
|
Hello @Janvi-Thakkar @Palaksharma23 @HarshCasper kindly review! |
There was a problem hiding this comment.
@abhilipsasahoo03 Thanks for your continuous efforts in implementing all the suggestions❤️. LGTM:)
abhilipsasahoo03
requested review from
shloka-gupta and
HarshCasper
and removed request for
HarshCasper and
shloka-gupta
Description
Fixes #54
Change log
Added pages for: