Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use api-snippets(thirdparty-api paths) in place of local defs #61

Merged
merged 6 commits into from
Mar 24, 2021
Merged

feat: use api-snippets(thirdparty-api paths) in place of local defs #61

merged 6 commits into from
Mar 24, 2021

Conversation

sridharvoruganti
Copy link
Contributor

@sridharvoruganti sridharvoruganti commented Mar 22, 2021 •
edited
Loading

this is related to story #2089

@lewisdaly updated api definitions and modified code to support new payload.

@sridharvoruganti sridharvoruganti marked this pull request as ready for review March 22, 2021 18:22
lewisdaly
lewisdaly requested changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@lewisdaly lewisdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor nitpicks

test/unit/server/handlers/consents.test.ts Outdated Show resolved Hide resolved
src/server/handlers/consents.ts Outdated Show resolved Hide resolved
lewisdaly
lewisdaly reviewed Mar 23, 2021
View reviewed changes
src/interface/api-template.yaml Outdated Show resolved Hide resolved
src/interface/api-template.yaml Outdated Show resolved Hide resolved
eoln
eoln suggested changes Mar 23, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/__mocks__/server.ts Outdated Show resolved Hide resolved
src/server/handlers/consents.ts Outdated Show resolved Hide resolved
src/lib/db.ts Show resolved Hide resolved
src/lib/scopes.ts Show resolved Hide resolved
test/data/data.ts Outdated Show resolved Hide resolved
src/domain/consents.ts Outdated Show resolved Hide resolved
test/data/data.ts Outdated Show resolved Hide resolved
test/data/data.ts Show resolved Hide resolved
test/data/data.ts Show resolved Hide resolved
@sridharvoruganti sridharvoruganti mentioned this pull request Mar 23, 2021
Closed
32 tasks
eoln
eoln suggested changes Mar 23, 2021
View reviewed changes
src/server/handlers/consents.ts Show resolved Hide resolved
src/server/handlers/index.ts Show resolved Hide resolved
@sridharvoruganti sridharvoruganti merged commit 3667b9a into mojaloop:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewisdaly lewisdaly lewisdaly approved these changes

@eoln eoln eoln approved these changes

@kleyow kleyow kleyow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sridharvoruganti @lewisdaly @eoln @kleyow