Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use api-snippets(thirdparty-api paths) in place of local defs #61

Merged
merged 6 commits into from
Mar 24, 2021
Merged

feat: use api-snippets(thirdparty-api paths) in place of local defs #61

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
44a48d9
feat: use api-snippets(thirdparty-api paths) in place of local defs
sridharvoruganti Mar 22, 2021
3a9868f
chore: fix linting issues
sridharvoruganti Mar 22, 2021
24ef0b5
chore: increase Consents id column length
sridharvoruganti Mar 22, 2021
175b8e6
chore: fix integration tests
sridharvoruganti Mar 22, 2021
766db21
chore: remove generateChallenge and revoke endpoints
sridharvoruganti Mar 23, 2021
092de58
chore: address review comments
sridharvoruganti Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
node_modules/**/*.js
coverage/*
.circleci/*
ambient.d.ts
commitlint.config.js
42,595 changes: 15 additions & 42,580 deletions audit-resolve.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion migrations/20200624121732_consent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export async function up (knex: Knex): Promise<void | Knex.SchemaBuilder> {
return knex.schema.createTable('Consent',
(t: Knex.CreateTableBuilder): void => {
// TODO: Confirm string length for status and revoked at
t.string('id', 32).primary().notNullable()
t.string('id', 36).primary().notNullable()
eoln marked this conversation as resolved.
Show resolved Hide resolved
t.string('status', 32).notNullable()
t.string('initiatorId', 32).notNullable()
t.string('participantId', 32).notNullable()
Expand Down
2 changes: 1 addition & 1 deletion migrations/20200624121736_scope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export async function up (knex: Knex): Promise<Knex.SchemaBuilder | void> {
if (!exists) {
return knex.schema.createTable('Scope', (t: Knex.CreateTableBuilder): void => {
t.increments('id').primary().notNullable()
t.string('consentId', 32).notNullable()
t.string('consentId', 36).notNullable()
t.string('action', 36).notNullable()
t.string('accountId', 36).notNullable()

Expand Down
Loading