feat: implement register consent flow #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleyow
force-pushed
the
feat/consent-register
branch
from
65c4c3f
to
0296f7c
Compare
lewisdaly
approved these changes
Jul 13, 2021
| const payload: fspiopAPI.Schemas.ParticipantsTypeIDSubIDPostRequest = { | ||
| fspId: this.config.authServiceParticipantFSPId | ||
| } | ||
| const res = await axios.post(alsParticipantURI, payload, axiosConfig) |
There was a problem hiding this comment.
There was a problem hiding this comment.
We don't have type definitions for BaseRequests and instead of defining all the types this was easier until I can commit a postParticipantsTypeId function to sdk-standard-components.
| import ParticipantsTypeIDHandler from '~/server/handlers/participants/{Type}/{ID}' | ||
| import { StateResponseToolkit } from '../../../../../../src/server/plugins/state'; |
There was a problem hiding this comment.
Any reason to use these instead of the ~?
There was a problem hiding this comment.
auto import in vscode imports them like this and I sometimes miss it.
been meaning to find a way to fix that.
|
Going to merge this for now o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.