Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mojaloop/#2734): failures in daily cron job running gp tests #146

Merged

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Sep 6, 2022

fix(mojaloop/#2734): failures in daily cron job running gp tests - mojaloop/project#2734

  • fixed logging to correctly display request logs. this is needed to help debug issues
  • re-factored config-loading as this was incorrectly being handled all-over the place, which impacted unit/integration tests etc.
  • added unit tests for config-loading
  • added support for CONFIG_OVERRIDE env var to support using example.env for unit/integration tests, with default being .env when running npm start.

chore: maintenance

  • updated dependencies
  • updated husky to the latest version, and moved config from package.json to .husky folder
  • replaced module-alias with native import alias's

- fixed logging to correctly display request logs. this is needed to help debug issues
- updated dependencies
- updated husky to latest version, and moved config from package.json to .husky folder
- replaced module-alias with native import aliass
@mdebarros
Copy link
Member Author

mdebarros commented Sep 6, 2022

Example request being logged with actual request BODY (previously missing):

{
  app: 'test-api',
  request: {
    id: 'whining-creamy-late-salesclerk',
    path: '/repository/parties',
    method: 'POST'
  },
  body: { <-- This was previously missing
    displayName: 'testfsp4WalletFname testfsp4WalletLname',
    firstName: 'testfsp4WalletFname',
    middleName: '',
    lastName: 'testfsp4WalletLname',
    dateOfBirth: '1985-05-13',
    idType: 'MSISDN',
    idValue: '17891239872',
    extensionList: [ { key: 'accountType', value: 'Wallet' } ]
  },
  msg: 'Request received',
  timestamp: '2022-09-06T10:50:30.615Z'
}

elnyry-sam-k
elnyry-sam-k previously approved these changes Sep 7, 2022
@mdebarros mdebarros merged commit 50ebcad into master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants