Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on org secret for build pipeline #61

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Remove dependency on org secret for build pipeline #61

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83f633b
Remove dependency on org secret for build pipeline
KamuelaFranco Jul 13, 2020
3dbd445
Update config.yml
KamuelaFranco Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,10 @@ jobs:
--build-arg VERSION="local"
--build-arg SOURCE="$CIRCLE_REPOSITORY_URL"
--build-arg REVISION="$CIRCLE_SHA1"
-t $DOCKER_ORG/$CIRCLE_PROJECT_REPONAME:local .
-t mojaloop/$CIRCLE_PROJECT_REPONAME:local .
- run:
name: Save docker image to workspace
command: docker save -o /tmp/docker-image.tar $DOCKER_ORG/$CIRCLE_PROJECT_REPONAME:local
command: docker save -o /tmp/docker-image.tar mojaloop/$CIRCLE_PROJECT_REPONAME:local
- persist_to_workspace:
root: /tmp
paths:
Expand All @@ -298,10 +298,10 @@ jobs:
--build-arg VERSION="local"
--build-arg SOURCE="$CIRCLE_REPOSITORY_URL"
--build-arg REVISION="$CIRCLE_SHA1"
-t $DOCKER_ORG/onboard-central-ledger:local ./init/onboard-central-ledger/
-t mojaloop/onboard-central-ledger:local ./init/onboard-central-ledger/
- run:
name: Save docker image to workspace
command: docker save -o /tmp/docker-onboard-central-ledger.tar $DOCKER_ORG/onboard-central-ledger:local
command: docker save -o /tmp/docker-onboard-central-ledger.tar mojaloop/onboard-central-ledger:local
- persist_to_workspace:
root: /tmp
paths:
Expand All @@ -321,10 +321,10 @@ jobs:
--build-arg VERSION="local"
--build-arg SOURCE="$CIRCLE_REPOSITORY_URL"
--build-arg REVISION="$CIRCLE_SHA1"
-t $DOCKER_ORG/onboard-msisdn-oracle:local ./init/onboard-msisdn-oracle/
-t mojaloop/onboard-msisdn-oracle:local ./init/onboard-msisdn-oracle/
- run:
name: Save docker image to workspace
command: docker save -o /tmp/docker-onboard-msisdn-oracle.tar $DOCKER_ORG/onboard-msisdn-oracle:local
command: docker save -o /tmp/docker-onboard-msisdn-oracle.tar mojaloop/onboard-msisdn-oracle:local
- persist_to_workspace:
root: /tmp
paths:
Expand All @@ -343,7 +343,7 @@ jobs:
<<: *defaults_license_scanner
- run:
name: Run the license-scanner
command: cd /tmp/license-scanner && mode=docker dockerImages=$DOCKER_ORG/$CIRCLE_PROJECT_REPONAME:local make run
command: cd /tmp/license-scanner && mode=docker dockerImages=mojaloop/$CIRCLE_PROJECT_REPONAME:local make run
- store_artifacts:
path: /tmp/license-scanner/results
prefix: licenses
Expand All @@ -363,7 +363,7 @@ jobs:
command: docker load -i /tmp/docker-image.tar
- anchore/analyze_local_image:
dockerfile_path: ./Dockerfile
image_name: ${DOCKER_ORG}/${CIRCLE_PROJECT_REPONAME}:local
image_name: mojaloop/${CIRCLE_PROJECT_REPONAME}:local
# Anchore bug: if policy_failure is `true`, reports don't get written - we manually check for failures below
policy_failure: false
timeout: '500'
Expand All @@ -381,12 +381,12 @@ jobs:
printf "\n%s\n" "The following vulnerabilities were found:"
jq '[.vulnerabilities | group_by(.package) | .[] | {package: .[0].package, vuln: [.[].vuln]}]' anchore-reports/*vuln*.json
fi
- run:
name: Upload Anchore reports to s3
command: |
aws s3 cp anchore-reports ${AWS_S3_DIR_ANCHORE_REPORTS}/${CIRCLE_PROJECT_REPONAME}/ --recursive
aws s3 rm ${AWS_S3_DIR_ANCHORE_REPORTS}/latest/ --recursive --exclude "*" --include "${CIRCLE_PROJECT_REPONAME}*"
aws s3 cp anchore-reports ${AWS_S3_DIR_ANCHORE_REPORTS}/latest/ --recursive
# - run:
# name: Upload Anchore reports to s3
# command: |
# aws s3 cp anchore-reports ${AWS_S3_DIR_ANCHORE_REPORTS}/${CIRCLE_PROJECT_REPONAME}/ --recursive
# aws s3 rm ${AWS_S3_DIR_ANCHORE_REPORTS}/latest/ --recursive --exclude "*" --include "${CIRCLE_PROJECT_REPONAME}*"
# aws s3 cp anchore-reports ${AWS_S3_DIR_ANCHORE_REPORTS}/latest/ --recursive

# TODO: Enable this when we want to increase the strictness of our security policies
# failCount=$(cat anchore-reports/*policy*.json | grep 'fail' | wc -l)
Expand Down