Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linking] - Invalid scopes handling #2001

Closed
23 tasks done
lewisdaly opened this issue Jan 28, 2021 · 2 comments
Closed
23 tasks done

[linking] - Invalid scopes handling #2001

lewisdaly opened this issue Jan 28, 2021 · 2 comments
Assignees
Labels
oss-pisp OSS PISP team's items - stories, bugs, epics story
Milestone

Comments

@lewisdaly
Copy link
Contributor

lewisdaly commented Jan 28, 2021

Goal:

As a user

I want to be informed if the accounts I've selected for linking are not available, or the account actions are not allowed

so that I can restart the linking process from scratch

Acceptance Criteria:

  • updated/new sequence diagram with error callback from DFSP for an invalid set of scopes: PUT /consentRequests/{id}/error
  • end to end test that produces a PUT /consentRequests/{id}/error for a bad accountId

Complexity: High

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

  • update sequence diagrams and error codes
  • update the handling of POST /consentRequests in the thirdparty-api-adapter
  • implement a test scenario on the DFSP to call PUT /consentRequests/{id}/error when receiving a bad set of scopes
  • handle PUT /consentRequests/{id}/error in the thirdparty-api-adapter
  • implement POST /consentRequests in the thirdparty-scheme-adapter inbound
  • handle PUT /consentRequests/{id}/error in the thirdparty-scheme-adapter inbound
  • implement POST /consentRequests endpoint in the thirdparty-scheme-adapter outbound
  • implement validateConsentRequests endpoint in mojaloop-simulator
  • end to end test for this error callback on the PISP's side
  • add all possible error scenarios
    Done
  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@lewisdaly lewisdaly added oss-pisp OSS PISP team's items - stories, bugs, epics story labels Jan 28, 2021
@lewisdaly
Copy link
Contributor Author

I think this one should wait for now - JJ, Michael and I were discussing an update to the PUT /consentRequests/{id} body that would include the accountIdentifier to make the scopes lookup on the DFSP side much easier.

@sridharvoruganti sridharvoruganti self-assigned this Mar 30, 2021
@sridharvoruganti sridharvoruganti added this to the Sprint 13.5 milestone Mar 30, 2021
@lewisdaly
Copy link
Contributor Author

Sequences are updated, so please go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oss-pisp OSS PISP team's items - stories, bugs, epics story
Projects
None yet
Development

No branches or pull requests

2 participants