Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e tests for consentRequests #131

Merged
merged 6 commits into from
Apr 19, 2021
Merged

test: add e2e tests for consentRequests #131

merged 6 commits into from
Apr 19, 2021

Conversation

sridharvoruganti
Copy link
Contributor

Closes #2001

eoln
eoln previously approved these changes Apr 14, 2021
docker-local/dfsp_b/rules.json Show resolved Hide resolved
docker-local/dfsp_a/rules.json Outdated Show resolved Hide resolved
docs/linking/2-request-consent-otp.puml Outdated Show resolved Hide resolved
docs/linking/2-request-consent-web.puml Outdated Show resolved Hide resolved
@eoln eoln self-requested a review April 15, 2021 08:03
eoln
eoln previously approved these changes Apr 16, 2021
Copy link
Contributor

@eoln eoln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is really great we have finally documented error cases for consent request!
I am really happy to see superb high-quality work done by @sridharvoruganti

  • little improvement in doc can be done -> let put on the list of error cases also error codes

docs/linking/README.md Outdated Show resolved Hide resolved
lewisdaly
lewisdaly previously approved these changes Apr 19, 2021
@sridharvoruganti sridharvoruganti dismissed stale reviews from lewisdaly and eoln via d45c17f April 19, 2021 11:24
Copy link
Contributor

@eoln eoln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sridharvoruganti sridharvoruganti merged commit 517bdc8 into mojaloop:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants