fix: fix party lasterror logic

mojaloop · Nov 9, 2022 · a232def · a232def
1 parent 3e6156a
commit a232def
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/...and-event-handler/src/domain/bulk_transaction_agg/handlers/process_party_info_callback.ts b/...and-event-handler/src/domain/bulk_transaction_agg/handlers/process_party_info_callback.ts
@@ -131,16 +131,22 @@ export async function handleProcessPartyInfoCallbackCmdEvt(
                     const individualTransferData = await bulkTransactionAgg
                         .getIndividualTransferById(individualTransferId);
 
+                    const lastError = (
+                        individualTransferData.partyResponse?.errorInformation && {
+                            mojaloopError: individualTransferData.partyResponse?.errorInformation,
+                        }) || (
+                        individualTransferData.lastError && {
+                            mojaloopError: individualTransferData.lastError.mojaloopError,
+                        });
+
                     // Individual transfers where `partyResult.currentState` does
                     // not match SDKOutboundTransferState.COMPLETED will have no `partyResponse`
                     // set. `transactionId` and `homeTransaction` still need to be set.
                     individualTransferResults.push({
                         homeTransactionId: individualTransferData.request.homeTransactionId,
                         transactionId: individualTransferData.id,
                         to: individualTransferData.partyResponse?.party,
-                        lastError: individualTransferData.lastError && {
-                            mojaloopError: individualTransferData.lastError.mojaloopError,
-                        },
+                        lastError,
                     });
                 }
                 const sdkOutboundBulkAcceptPartyInfoRequestedDmEvt = new SDKOutboundBulkAcceptPartyInfoRequestedDmEvt({