feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of TransferId feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId - mojaloop/project#3018 - bumped api-snippets to v17.0.0-snapshot.0 --> TODO: Upgrade this to final version once PR (mojaloop/api-snippets#148) has been merged - updated applicable events to include the transferId - updated aggregate handlers to correctly map the transferId instead of the transactionId - updated TTK API definitions for SDK Outbound API specifications (copied from API-Snippets) - updated TTK Test Case "bulk_happy_path_dynamic" to correctly use the transferId instead of the transactionId chore: improvements to docker-compose for debugging - added "start:debug" to each of the modules to start with debugging enabled - updated docker-compose to use the "start:debug" command to be able to attach and debug issues
mdebarros
requested review from
elnyry-sam-k,
vijayg10 and
kleyow
as code owners
36 tasks
- updated mappings based on the api-snippets changes - updated api_specs for fun-test TTK api definitions
…cks from bulk_happy_path_dynamic func test
…ionId-is-being-used-instead-of-TransferId
kleyow
approved these changes
Nov 12, 2022
kleyow
deleted the
feat/#3018-TransactionId-is-being-used-instead-of-TransferId
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId - mojaloop/project#3018
TODO: Upgrade this to final version once PR (feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId api-snippets#148) has been mergedchore: improvements to docker-compose for debugging