Feature/narayans/storage

[nsainaney]

Added storage using v1 endpoints as well as got all unit tests working

[sureshven]

In 'MojioSDK/Client/RestClient.swift' theres some commented out code at 229

'/*switch self.requestEntity! {'

[sureshven]

In RestClient.swift (229) there's some commented out code - do we need keep that around?

'/*switch self.requestEntity! {' ...

[adamtswu]

Yes. I forgot to clean that up.

On Thu, May 26, 2016, 5:50 PM Suresh Venkatraman notifications@github.com
wrote:

In 'MojioSDK/Client/RestClient.swift' theres some commented out code at 229

'/*switch self.requestEntity! {'

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#32 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ANDFW4MYLt3COsuKIxz4mp8QSLFwbf-Pks5qFj_ggaJpZM4IoEc5
.

[sureshven]

Question: What are your thoughts on delaying URL construction until a run request is made or explicitly having a build() call so that we don't need to rewrite the request URL multiple times.

[adamtswu]

I'm fine with that. Frankly, I'd also prefer returning a Promise so we
don't have these silly Christmas tree like code.

N
On Thu, May 26, 2016 at 6:06 PM Suresh Venkatraman notifications@github.com
wrote:

Question: What are your thoughts on delaying URL construction until a run
request is made or explicitly having a build() call so that we don't need
to rewrite the request URL multiple times.

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#32 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ANDFW1vgKVdZZWNoYijC0g03lIiSmN5Jks5qFkOOgaJpZM4IoEc5
.

[sureshven]

That's one of the things that can be revisited but makes sense.