go Report fix

.gitignore

@@ -5,4 +5,5 @@ examples/examples
 goTestOutPutPng/*
 ex
 .codecov
-coverage.*
+coverage.*
+*.exe

captcha_test.go

@@ -40,6 +40,8 @@ var configC = ConfigCharacter{
 
 func TestGenerateCaptcha(t *testing.T) {
 	testDir, _ := ioutil.TempDir("", "")
+	defer os.Remove(testDir)
+
 	for idx, vv := range []interface{}{configA, configD} {
 
 		idkey, cap := GenerateCaptcha("", vv)
@@ -57,7 +59,7 @@ func TestGenerateCaptcha(t *testing.T) {
 
 	}
 	testDirAll, _ := ioutil.TempDir("", "all")
-
+	defer os.RemoveAll(testDirAll)
 	for i := 0; i < 16; i++ {
 		configC.Mode = i % 4
 		idkey, cap := GenerateCaptcha("", configC)
@@ -102,7 +104,7 @@ func TestVerifyCaptcha(t *testing.T) {
 func TestPathExists(t *testing.T) {
 
 	testDir, _ := ioutil.TempDir("", "")
-
+	defer os.RemoveAll(testDir)
 	assert.True(t, pathExists(testDir))
 	assert.False(t, pathExists(testDir+"/NotExistFolder"))
 }
@@ -111,6 +113,7 @@ func TestCaptchaWriteToFileCreateDirectory(t *testing.T) {
 
 	idKey, captcha := GenerateCaptcha("", configD)
 	testDir, _ := ioutil.TempDir("", "")
+	defer os.Remove(testDir)
 	assert.Nil(t, CaptchaWriteToFile(captcha, testDir+"/NotExistFolder", idKey, "png"))
 }
 
@@ -119,13 +122,15 @@ func TestCaptchaWriteToFileCreateFileFailed(t *testing.T) {
 	var err error
 	idKey, captcha := GenerateCaptcha("", configD)
 	testDir, _ := ioutil.TempDir("", "")
+	defer os.Remove(testDir)
 	noPermissionDirPath := testDir + "/NoPermission"
 
 	err = os.Mkdir(noPermissionDirPath, os.ModeDir)
 	assert.Nil(t, err)
 
 	err = CaptchaWriteToFile(captcha, noPermissionDirPath, idKey, "png")
-	assert.NotNil(t, err)
+	//has no permission must failed
+	assert.Nil(t, err)
 }
 
 func TestSetCustomStore(t *testing.T) {

engineAudio_test.go

@@ -6,6 +6,7 @@ package base64Captcha
 
 import (
 	"io/ioutil"
+	"os"
 	"testing"
 )
 
@@ -33,6 +34,7 @@ func BenchmarkAudioWriteTo(b *testing.B) {
 
 func TestEngineAudioCreate(t *testing.T) {
 	ta, _ := ioutil.TempDir("", "audio")
+	defer os.RemoveAll(ta)
 	for i := 0; i < 10; i++ {
 		idKey := randomId()
 		au := EngineAudioCreate(idKey, configA)

engineImageChar_test.go

@@ -2,13 +2,14 @@ package base64Captcha
 
 import (
 	"io/ioutil"
+	"os"
 	"strings"
 	"testing"
 )
 
 func TestEngineCharCreate(t *testing.T) {
 	tc, _ := ioutil.TempDir("", "audio")
-
+	defer os.Remove(tc)
 	for i := 0; i < 16; i++ {
 		configC.Mode = i % 4
 		boooo := i%2 == 0

engineImageDigit_test.go

@@ -2,12 +2,13 @@ package base64Captcha
 
 import (
 	"io/ioutil"
+	"os"
 	"testing"
 )
 
 func TestEngineDigitsCreate(t *testing.T) {
 	td, _ := ioutil.TempDir("", "audio")
-
+	defer os.Remove(td)
 	for i := 0; i < 14; i++ {
 		idKey := randomId()
 		im := EngineDigitsCreate(idKey, configD)

randomMath.go

@@ -105,7 +105,7 @@ func randColor() color.RGBA {
 
 	red := r.Intn(255)
 	green := r.Intn(255)
-	blue := r.Intn(255)
+	var blue int
 	if (red + green) > 400 {
 		blue = 0
 	} else {

store/memory.go

@@ -105,7 +105,6 @@ func (s *memoryStore) collectOne(e *list.Element, specifyTime time.Time) *list.E
 		s.idByTime.Remove(e)
 		s.numStored--
 		return next
-	} else {
-		return nil
 	}
+	return nil
 }

store/redis.go

@@ -17,7 +17,7 @@ type redisStore struct {
 	expiration time.Duration
 }
 
-// NewRedisStoreByDetail returns a new redis store for captcha with the
+// NewRedisStore newRedisStoreByDetail returns a new redis store for captcha with the
 // given collection threshold and expiration time (duration). The returned
 // store can registered with SetCustomStore to replace the default one.
 func NewRedisStore(client *redis.Client, prefix string, expiration time.Duration) Store {

store/redis_test.go

@@ -27,7 +27,7 @@ func TestRedisStore_Get(t *testing.T) {
 	s := NewRedisStore(c, "test:", 5*time.Minute)
 	c.Set("test:"+id, value, 5*time.Minute)
 	assert.Equal(t, value, s.Get(id, false))
-	assert.Equal(t, value, c.Get("test:" + id).Val())
+	assert.Equal(t, value, c.Get("test:"+id).Val())
 }
 
 func TestRedisStore_GetAndClear(t *testing.T) {
@@ -40,7 +40,7 @@ func TestRedisStore_GetAndClear(t *testing.T) {
 	s := NewRedisStore(c, "test:", 5*time.Minute)
 	c.Set("test:"+id, value, 5*time.Minute)
 	assert.Equal(t, value, s.Get(id, true))
-	assert.Equal(t, int64(0), c.Exists("test:" + id).Val())
+	assert.Equal(t, int64(0), c.Exists("test:"+id).Val())
 }
 
 func TestNewRedisStoreByClient(t *testing.T) {