Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin > Purchases, Capture link incorrect for prod #62

Closed
rpcme opened this issue Apr 20, 2015 · 4 comments
Closed

Admin > Purchases, Capture link incorrect for prod #62

rpcme opened this issue Apr 20, 2015 · 4 comments
Assignees
Labels

Comments

@rpcme
Copy link

rpcme commented Apr 20, 2015

The Captured link points to test dashboard, not live dashboard. In such case, a 404 is returned.

Please change:

test => ""

meaning:

https://dashboard.stripe.com/test/payments/(token)
->
https://dashboard.stripe.com/payments/(token)

@jhthorsen
Copy link

This is not the best fix. I think this external_link() method should be moved into the application, so it can create a more dynamic link, dependent on the environment the application is started in.... But, I don't care enough to fix that properly now.

@rpcme
Copy link
Author

rpcme commented Apr 21, 2015

is it more of a plugin bug then?

@jhthorsen
Copy link

"plugin bug" ? The issue is c649d06#diff-e15a064597b678f36010375e3cb51501R7

@rpcme
Copy link
Author

rpcme commented Apr 21, 2015

Oh! I thought maybe you were getting it from a helper in your stripe plugin. My bad!

On Apr 21, 2015, at 3:35 PM, Jan Henning Thorsen notifications@github.com wrote:

"plugin bug" ? The issue is c649d06#diff-e15a064597b678f36010375e3cb51501R7 c649d06#diff-e15a064597b678f36010375e3cb51501R7

Reply to this email directly or view it on GitHub #62 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants