Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#75 Supporting module path given as string #100

Closed
wants to merge 2 commits into from

Conversation

gunnarmorling
Copy link

This also incorporates my other fix for issue #98, i.e. when merging this PR, #99 can be closed.

…so to make sure it can be resolved correctly within multi-module builds and if another name than "target" has been configured
@ctubbsii
Copy link

ctubbsii commented Jun 5, 2018

I do not think this fixes the entire bug in #75. This code still assumes that when -p is seen in the arguments, it refers to a module path. However, that is not the case when executing something like
mkdir -p:

             <configuration>                                                                         
               <executable>mkdir</executable>                                                        
               <arguments>                                                                           
                 <argument>-p</argument>                                                             
                 <argument>${project.build.directory}/generated-docs</argument>                      
               </arguments>                                                                          
             </configuration>  

@rfscholte
Copy link
Member

This should be fixed with 3296fc8

@rfscholte rfscholte closed this Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants