Issue #74: Add display-extension-updates #908

jarmoniuk · 2023-01-24T21:47:45Z

First stage of extensions support.

Not supporting core extensions. Only build extensions are supported.

@slawekjaranowski please review

slawekjaranowski

Extension can also by defined in .mvn/extensions.xml
https://maven.apache.org/configure.html#mvn-extensions-xml-file

versions-common/src/main/java/org/codehaus/mojo/versions/utils/ExtensionBuilder.java

jarmoniuk · 2023-01-25T19:47:34Z

@slawekjaranowski added support for core extensions declared in .mvn/extensions.xml

slawekjaranowski · 2023-02-01T18:56:26Z

versions-common/src/main/java/org/codehaus/mojo/versions/utils/CoreExtensionUtils.java

+     * @since 2.15.0
+     */
+    public static Stream<Extension> getCoreExtensions(MavenSession session) throws IOException, XmlPullParserException {
+        Path extensionsFile = session.getCurrentProject().getBasedir().toPath().resolve(".mvn/extensions.xml");


What with multimdule projects?
getBasedir - returns path to current module - imho it is not Maven project root - should be checked by IT

slawekjaranowski · 2023-02-01T18:57:59Z

versions-common/src/main/java/org/codehaus/mojo/versions/utils/CoreExtensionUtils.java

+import java.nio.file.Path;
+import java.util.stream.Stream;
+
+import org.apache.maven.cli.internal.extension.model.io.xpp3.CoreExtensionsXpp3Reader;


internal implementation ... can be changed - it is risik to use it

versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/DisplayExtensionUpdatesMojo.java

versions-model-core-extensions/src/main/mdo/core-extensions.mdo

slawekjaranowski · 2023-02-12T23:39:36Z

versions-maven-plugin/src/it/it-display-extension-updates-004/child/.mvn/extensions.xml

+<extensions xmlns="http://maven.apache.org/EXTENSIONS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+            xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0 http://maven.apache.org/xsd/core-extensions-1.0.0.xsd">


Core extensions can be defined only in project root - in child module it will be skipped as I know.

I don't see a check for dummy-impl so why this file exists?

versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/DisplayExtensionUpdatesMojo.java

slawekjaranowski · 2023-02-16T19:37:14Z

@ajarmoniuk please rebase this PR ... now I see in diff changes from master ...

jarmoniuk · 2023-02-16T19:58:26Z

@ajarmoniuk please rebase this PR ... now I see in diff changes from master ...

Rebased.

slawekjaranowski

Ok, I see
you create new module versions-model-core-extensions with contain a copy file core-extensions.mdo from Maven core.

I think that better will be use org.apache.maven.cli.internal.extension.model.io.xpp3.CoreExtensionsXpp3Reader even it is internal

slawekjaranowski · 2023-02-18T12:40:15Z

pom.xml

@@ -126,6 +127,7 @@
    <maven.compiler.source>${mojo.java.target}</maven.compiler.source>
    <junitBomVersion>5.9.1</junitBomVersion>
    <mavenVersion>3.2.5</mavenVersion>
+    <mavenEmbedderVersion>3.3.9</mavenEmbedderVersion>


It is from Maven Core should have the same version as used Maven api and so on

slawekjaranowski · 2023-02-18T19:07:43Z

versions-maven-plugin/src/it/it-display-extension-updates-004/child/.mvn/extensions.xml

+<extensions xmlns="http://maven.apache.org/EXTENSIONS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+            xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0 http://maven.apache.org/xsd/core-extensions-1.0.0.xsd">


I don't see a check for dummy-impl so why this file exists?

jarmoniuk · 2023-02-18T19:19:36Z

Ok, I see you create new module versions-model-core-extensions with contain a copy file core-extensions.mdo from Maven core.

I think that better will be use org.apache.maven.cli.internal.extension.model.io.xpp3.CoreExtensionsXpp3Reader even it is internal

Are you sure?

I asked you before when you requested me to change that:

Ok, so I have a question about this. Maybe I could appeal to the Maven project to make this public, or at least export the mdo?

I could also include the mdo file in the versions plugin. But what about its license then? > It's the ASF -- should we keep it as ASF then?

As an alternative, I could create a parser from scratch, be it manually, or using a bespoke XSD file and generate a parser from it.

So, what do you think should be the course of action here?

So, what should it be? I'll wait.

jarmoniuk · 2023-02-18T19:21:48Z

I don't see a check for dummy-impl so why this file exists?

to test if the .mvn/extensions is not processed in the child.

jarmoniuk · 2023-02-18T19:45:53Z

@slawekjaranowski and if you need time to decide, feel free to remove this from the upcoming release.

It's not so easy.

Maven Embedder 3.2.5 does not have the Core Extensions parser. Only 3.3.9 and later has it. So we cannot use the one from the same version as Maven.

https://maven.apache.org/ref/3.2.5/maven-embedder/xref/index.html

slawekjaranowski · 2023-02-19T09:44:42Z

@slawekjaranowski and if you need time to decide, feel free to remove this from the upcoming release.

It's not so easy.

Maven Embedder 3.2.5 does not have the Core Extensions parser. Only 3.3.9 and later has it. So we cannot use the one from the same version as Maven.

https://maven.apache.org/ref/3.2.5/maven-embedder/xref/index.html

Ok, I must review of it more carefully ... so I will do it again in next week

Maybe some one else want to look also - @slachiewicz ?

jarmoniuk · 2023-02-19T10:04:52Z

@slawekjaranowski @slachiewicz

It's not the only case like this in this plugin. Please have a look at e.g. parsing raw pom. Currently it's an ad-hoc parser created from scratch in the plugin, but it actually depends on a document defined and owned by the Maven project. So it's a very similar case.

jarmoniuk · 2023-02-27T20:14:54Z

@slawekjaranowski I propose that we keep a version of this PR with the file from the Apache Maven project with its own ASF license and its own Modello version. Until there comes an API from Maven, which we can request or implement.

slawekjaranowski

I think that we not need new module only for a few classes, we not need xsd for it, it is only for internal purpose.

I would like to put core-extensions.mdo into versions-common where is only used.

pom.xml

slawekjaranowski · 2023-02-28T16:33:13Z

versions-model-core-extensions/pom.xml

+          <execution>
+            <id>generate-site-doc</id>
+            <goals>
+              <goal>xdoc</goal>


We should not generate xsd for this model - it is internally used for reading extensions.xml

versions-model-core-extensions/src/main/mdo/core-extensions.mdo

jarmoniuk · 2023-02-28T17:14:18Z

I think that we not need new module only for a few classes, we not need xsd for it, it is only for internal purpose.

I would like to put core-extensions.mdo into versions-common where is only used.

Applied.

jarmoniuk · 2023-02-28T17:48:45Z

I think that we not need new module only for a few classes, we not need xsd for it, it is only for internal purpose.

I would like to put core-extensions.mdo into versions-common where is only used.

Oh yes, I remember it now. The reason why I created that module was that I couldn't go around javadoc generation errors -- classes were generated.

I think that there is no easy way of hinting javadoc to use the autogenerated classes.

Exit code: 1
/Users/ajarmoniuk/IdeaProjects/versions-maven-plugin-2/versions-common/src/main/java/org/codehaus/mojo/versions/utils/CoreExtensionUtils.java:29: error: cannot find symbol
import org.codehaus.mojo.versions.model.io.xpp3.CoreExtensionsXpp3Reader;
^
symbol: class CoreExtensionsXpp3Reader
location: package org.codehaus.mojo.versions.model.io.xpp3
1 error
Command line was: /Users/ajarmoniuk/Library/Java/JavaVirtualMachines/openjdk-19.0.2/Contents/Home/bin/javadoc @options @packages

Refer to the generated Javadoc files in '/Users/ajarmoniuk/IdeaProjects/versions-maven-plugin-2/versions-common/target/site/apidocs' dir.

jarmoniuk · 2023-02-28T18:16:39Z

Deleting the contents of '/home/runner/work/versions/versions'
Initializing the repository
Disabling automatic garbage collection
Setting up auth
Fetching the repository
Removing auth
Error: The process '/usr/bin/git' failed with exit code 128

@slawekjaranowski @slachiewicz could you please restart?

jarmoniuk · 2023-04-17T07:00:37Z

@slawekjaranowski is there anything else to be done about this PR?

slawekjaranowski · 2023-05-09T20:38:45Z

Hi,
I was removed maven-embedder from dependency - we have a copy
I restored license header in files with longer history - we don't know why such license was used ...

Wait for build and we can go.

jarmoniuk marked this pull request as draft January 24, 2023 23:11

jarmoniuk force-pushed the issue-74-extensions-support branch from eca6dbc to 55bdfa1 Compare January 25, 2023 06:35

jarmoniuk marked this pull request as ready for review January 25, 2023 06:36

jarmoniuk force-pushed the issue-74-extensions-support branch from 55bdfa1 to 4119ff6 Compare January 25, 2023 06:43

slawekjaranowski reviewed Jan 25, 2023

View reviewed changes

versions-common/src/main/java/org/codehaus/mojo/versions/utils/ExtensionBuilder.java Outdated Show resolved Hide resolved

jarmoniuk force-pushed the issue-74-extensions-support branch 2 times, most recently from 852bdda to 36a8593 Compare January 25, 2023 19:46

jarmoniuk force-pushed the issue-74-extensions-support branch 3 times, most recently from b8dd20f to 76e0619 Compare January 25, 2023 20:01

jarmoniuk requested a review from slawekjaranowski January 28, 2023 08:26

slawekjaranowski requested changes Feb 1, 2023

View reviewed changes

jarmoniuk force-pushed the issue-74-extensions-support branch 4 times, most recently from c1580f4 to 5a37c0d Compare February 2, 2023 19:39

jarmoniuk requested a review from slawekjaranowski February 2, 2023 19:43

slawekjaranowski reviewed Feb 12, 2023

View reviewed changes

jarmoniuk force-pushed the issue-74-extensions-support branch from 5a37c0d to f0b85a5 Compare February 13, 2023 07:26

jarmoniuk requested a review from slawekjaranowski February 13, 2023 07:27

jarmoniuk force-pushed the issue-74-extensions-support branch 2 times, most recently from b3375b4 to a686ce2 Compare February 13, 2023 21:42

jarmoniuk force-pushed the issue-74-extensions-support branch from 51c498a to cf5aaaf Compare February 16, 2023 19:57

slawekjaranowski requested changes Feb 18, 2023

View reviewed changes

jarmoniuk force-pushed the issue-74-extensions-support branch from cf5aaaf to e9eed03 Compare February 18, 2023 19:24

jarmoniuk force-pushed the issue-74-extensions-support branch from e9eed03 to da43c20 Compare February 19, 2023 05:55

slawekjaranowski reviewed Feb 28, 2023

View reviewed changes

jarmoniuk force-pushed the issue-74-extensions-support branch 2 times, most recently from 950810f to ef5f771 Compare February 28, 2023 17:18

jarmoniuk requested a review from slawekjaranowski February 28, 2023 17:20

jarmoniuk force-pushed the issue-74-extensions-support branch from ef5f771 to 1e4bd55 Compare February 28, 2023 18:13

jarmoniuk force-pushed the issue-74-extensions-support branch from 1306c33 to 65125cc Compare April 18, 2023 06:59

slawekjaranowski added the enhancement label May 9, 2023

slawekjaranowski added this to the 2.16.0 milestone May 9, 2023

slawekjaranowski linked an issue May 9, 2023 that may be closed by this pull request

Support for reporting new extenions versions #74

Closed

slawekjaranowski force-pushed the issue-74-extensions-support branch from 65125cc to d5baff3 Compare May 9, 2023 20:02

Issue mojohaus#74: Add display-extension-updates

6d554df

slawekjaranowski force-pushed the issue-74-extensions-support branch from d5baff3 to 6d554df Compare May 9, 2023 20:18

slawekjaranowski approved these changes May 9, 2023

View reviewed changes

slawekjaranowski merged commit b3a4037 into mojohaus:master May 9, 2023
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue #74: Add display-extension-updates #908

Issue #74: Add display-extension-updates #908

jarmoniuk commented Jan 24, 2023

slawekjaranowski left a comment

jarmoniuk commented Jan 25, 2023 •

edited

slawekjaranowski Feb 1, 2023

slawekjaranowski Feb 1, 2023

slawekjaranowski Feb 12, 2023

slawekjaranowski Feb 18, 2023

slawekjaranowski commented Feb 16, 2023

jarmoniuk commented Feb 16, 2023

slawekjaranowski left a comment

slawekjaranowski Feb 18, 2023

slawekjaranowski Feb 18, 2023

jarmoniuk commented Feb 18, 2023 •

edited

jarmoniuk commented Feb 18, 2023

jarmoniuk commented Feb 18, 2023 •

edited

slawekjaranowski commented Feb 19, 2023

jarmoniuk commented Feb 19, 2023 •

edited

jarmoniuk commented Feb 27, 2023

slawekjaranowski left a comment

slawekjaranowski Feb 28, 2023

jarmoniuk commented Feb 28, 2023

jarmoniuk commented Feb 28, 2023 •

edited

jarmoniuk commented Feb 28, 2023

jarmoniuk commented Apr 17, 2023

slawekjaranowski commented May 9, 2023

		<extensions xmlns="http://maven.apache.org/EXTENSIONS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
		xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0 http://maven.apache.org/xsd/core-extensions-1.0.0.xsd">

Issue #74: Add display-extension-updates #908

Issue #74: Add display-extension-updates #908

Conversation

jarmoniuk commented Jan 24, 2023

slawekjaranowski left a comment

Choose a reason for hiding this comment

jarmoniuk commented Jan 25, 2023 • edited

slawekjaranowski Feb 1, 2023

Choose a reason for hiding this comment

slawekjaranowski Feb 1, 2023

Choose a reason for hiding this comment

slawekjaranowski Feb 12, 2023

Choose a reason for hiding this comment

slawekjaranowski Feb 18, 2023

Choose a reason for hiding this comment

slawekjaranowski commented Feb 16, 2023

jarmoniuk commented Feb 16, 2023

slawekjaranowski left a comment

Choose a reason for hiding this comment

slawekjaranowski Feb 18, 2023

Choose a reason for hiding this comment

slawekjaranowski Feb 18, 2023

Choose a reason for hiding this comment

jarmoniuk commented Feb 18, 2023 • edited

jarmoniuk commented Feb 18, 2023

jarmoniuk commented Feb 18, 2023 • edited

slawekjaranowski commented Feb 19, 2023

jarmoniuk commented Feb 19, 2023 • edited

jarmoniuk commented Feb 27, 2023

slawekjaranowski left a comment

Choose a reason for hiding this comment

slawekjaranowski Feb 28, 2023

Choose a reason for hiding this comment

jarmoniuk commented Feb 28, 2023

jarmoniuk commented Feb 28, 2023 • edited

jarmoniuk commented Feb 28, 2023

jarmoniuk commented Apr 17, 2023

slawekjaranowski commented May 9, 2023

jarmoniuk commented Jan 25, 2023 •

edited

jarmoniuk commented Feb 18, 2023 •

edited

jarmoniuk commented Feb 18, 2023 •

edited

jarmoniuk commented Feb 19, 2023 •

edited

jarmoniuk commented Feb 28, 2023 •

edited