Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Issues #16 (mojo parameter checks), with test cases #22

Closed
wants to merge 5 commits into from

Conversation

rosslamont
Copy link
Contributor

@rosslamont rosslamont commented Aug 13, 2017

Fixes:

Throws exceptions when bogus parameters are passed to the mojo.

....

Apologies for the multiple commits - the last commit reverts my files back to the original change. I'll re-add those changes in later PRs once this one is through.

Also, apologies for the 9 files, 7 are test case files, and they are pretty much copies of existing test cases.

@rosslamont rosslamont changed the title Fixes for Issues #16 and #17 (mojo parameter checks), with test cases Fixes for Issues #16 (mojo parameter checks), with test cases Aug 23, 2017
@khmarbaise
Copy link
Member

khmarbaise commented Aug 26, 2017

Hi, first thanks for your contributions but it's really needed to have only a single issue done within a single PR...which means you should make a single PR for a single issue...I'm appreciate to further help....furthermore could you please squash your commits into a single one to have the relationship into the history more clear and not distributed over several commits..

@rosslamont rosslamont closed this Aug 27, 2017
@rosslamont rosslamont deleted the master branch August 27, 2017 07:49
@rosslamont
Copy link
Contributor Author

Hi Karl,

Apologies for the run-around. I'm a bit embarrassed, I've been developing for 25 years, but I am new to git / github / open source. So I made a bit of a mess of my local trying to move my revisions aside, as I have quite a few. Long story short, I have my revisions parked in a side branch and I will feed them to you now slowly. But I had to drop my master and reset it back to the fork origin point, so this PR had to close. New PR is #23.

Cheers
Ross

@khmarbaise
Copy link
Member

no need to apologize. No problem. I'm doing dev for about 30 years+ etc. but I learned one important thing: I know that I know nothing which means I can always learn new things...and most important is: ask questions to learn... so not a problem....It's very good that are trying to contribute to open source projects...and I appreciate your efforts...If you have further problem don't hesitate to ask via email or on the mailing list https://groups.google.com/forum/#!forum/mojohaus-dev etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants