Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanity checks on mojo parameters missing #16

Closed
rosslamont opened this issue Aug 7, 2017 · 2 comments
Closed

Sanity checks on mojo parameters missing #16

rosslamont opened this issue Aug 7, 2017 · 2 comments
Assignees
@khmarbaise
Milestone
Release 1.0.2-beta-1

Comments

@rosslamont
Copy link
Contributor

rosslamont commented Aug 7, 2017 •
edited

There doesn't seem to be much sanity checking of mojo parameters. For example if I mistype the name of a catalog file, I would expect an error. The plugin just ignores my catalog.

Similarly, if I mistype the name of a directory in the validation set, the validation plugin does not fail. It does however make a log entry.
rosslamont added a commit to rosslamont/xml-maven-plugin that referenced this issue Aug 8, 2017
@rosslamont
Issue mojohaus#16 and mojohaus#17, test cases and fixes
c8aef20
@rosslamont
Copy link
Contributor Author

Fixed by pull request #18

@rosslamont rosslamont mentioned this issue Aug 13, 2017
Closed
@rosslamont rosslamont changed the title No error on faulty catalog specification Sanity checks on mojo parameters missing Aug 23, 2017
@rosslamont rosslamont mentioned this issue Aug 23, 2017
Closed
rosslamont added a commit to rosslamont/xml-maven-plugin that referenced this issue Aug 27, 2017
@rosslamont
Issue mojohaus#16 (mojo parameter sanity checks) - test cases and fixes.
7312af1 
Specifically:
 - ensure that the "dir" parameter points to an existent directory.  Current
behaviour is to ignore the directory and to report success.
 - ensure that any "catalog" parameter to an existent file.  Current behaviour
is to ignore the catalog silently.
khmarbaise added a commit that referenced this issue Aug 27, 2017
@khmarbaise
Merge pull request #23 from rosslamont/issue-16
761547c 
Issue #16 (mojo parameter sanity checks) - test cases and fixes.
@khmarbaise khmarbaise added this to the Release 1.0.2 milestone Aug 27, 2017
@khmarbaise khmarbaise self-assigned this Aug 27, 2017
@khmarbaise
Copy link
Member

Thanks for the PR by Ross Lamont.

@rosslamont rosslamont removed this from the Release 1.0.2 milestone Jan 16, 2018
@rosslamont rosslamont added this to the Release 1.0.2 milestone Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khmarbaise khmarbaise

Labels
None yet
Projects
None yet
Milestone
Release 1.0.2-beta-1
Development

No branches or pull requests
2 participants
@khmarbaise @rosslamont