Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all_settled method to Mojo::Promise #1423

Closed
kraih opened this issue Oct 14, 2019 · 2 comments
Closed

Add all_settled method to Mojo::Promise #1423

kraih opened this issue Oct 14, 2019 · 2 comments
Labels
help wanted scheduled
Milestone
9.0

Comments

@kraih
Copy link
Member

kraih commented Oct 14, 2019

Since browsers already have this implemented and allSettled is likely to make it into the final spec. We can add an experimental all_settled method to Mojo::Promise. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled
@kraih
Copy link
Member Author

kraih commented Oct 14, 2019 •
edited
Loading

For the result we probably don't need a whole new object, a hashref should be fine ({status => 'fulfilled', value => '...'} or {status => 'rejected', reason => '...'}).

@kraih kraih added this to the 9.0 milestone Oct 15, 2019
@kraih kraih pinned this issue Oct 15, 2019
@elcamlost elcamlost mentioned this issue Oct 19, 2019
Closed
@kraih
Copy link
Member Author

kraih commented Dec 23, 2019

Done. 3ac940c...b78d658

@kraih kraih closed this as completed Dec 23, 2019
@kraih kraih unpinned this issue May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted scheduled
Projects
None yet
Milestone
9.0
Development

Successfully merging a pull request may close this issue.

add experimental all_settled method to Mojo::Promise elcamlost/mojo
1 participant
@kraih