Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc on passing arguments and tests to check pass though to File::… #1049

Merged
merged 1 commit into from Feb 3, 2017

Conversation

kiwiroy
Copy link
Contributor

@kiwiroy kiwiroy commented Feb 3, 2017

Summary

Documentation and tests for arguments passed through from Mojo::File::make_path and Mojo::File::remove_tree to File::Path.

Motivation

🇳🇿 contribution

References

#1048

Copy link
Member

@marcusramberg marcusramberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


Create the directories if they don't already exist with L<File::Path>.
Create the directories if they don't already exist with L<File::Path>. Any
additional arguments are passed through unmodified to L<File::Path::make_path>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The L<File::Path::make_path> doesn't look right to me, does that actually lead anywhere?

@kraih kraih merged commit f48e67a into mojolicious:master Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants