Add 'special' attribute to Mojolicious::Static #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this solution. But i think the attribute should have a more generic name, since anyone can add more "special" files (which is fine). And of course the implementation needs to be cleaner, and tests/documentation added. |
lindleyw
force-pushed
the
enumerated-bundled
branch
2 times, most recently
from
2305883
to
c08c65c
Compare
lindleyw
changed the title
kraih
requested changes
Jul 26, 2017
lib/Mojolicious/Static.pm
Outdated
| app->home->child('resources', 'jquery.js'); | ||
|
|
||
| would override the built-in jQuery for error pages with one in the app's | ||
| C<resources> directory. |
There was a problem hiding this comment.
This is not the correct documentation format for attributes. Please replicate the style of the surrounding documentation.
lib/Mojolicious/Static.pm
Outdated
| return $self->_get_file(path($PUBLIC, split('/', $rel))->to_string); | ||
| # Search special files | ||
| return undef unless exists $self->special->{$rel}; | ||
| return $self->_get_file($self->special->{$rel}); |
There was a problem hiding this comment.
The attribute accessor is called twice.
my $special = $self->special;
return exists $special->{$rel} ? $self->_get_file($special->{$rel}) : undef;
lib/Mojolicious/Static.pm
Outdated
| ) | ||
| } | ||
| }; | ||
| }; |
There was a problem hiding this comment.
I doubt the $_->to_rel($public)->to_string works on Windows.
There was a problem hiding this comment.
Confirmed by AppVeyor test results.
…verriding, or disabling any or all bundled files. Resolves mojolicious#1094 change 'bundled' to 'special'; add document
lindleyw
force-pushed
the
enumerated-bundled
branch
from
c08c65c
to
118a0c4
Compare
kraih
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to permit examining, overriding, or disabling any or all bundled files. May resolve #1094
Summary
Enumerate bundled, static files so application can examine or modify their resolution at runtime. For example, a Mojolicious::Lite app could:
and then proceed to serve
favicon.icofrom a route.would override the built-in jQuery for error pages with one in the app's
resourcesdirectory.Note: It might also be desirable to permit values which are Mojo::Asset objects, rather than filenames.
References
issue #1094