fix SSL_ca_file reference to undef #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudler
force-pushed
the
master
branch
4 times, most recently
from
7c0f82d
to
32e35b0
Compare
kraih
requested changes
Sep 6, 2017
lib/Mojo/IOLoop/TLS.pm
Outdated
| @@ -9,6 +9,9 @@ use Scalar::Util 'weaken'; | |||
| use constant TLS => $ENV{MOJO_NO_TLS} | |||
| ? 0 | |||
| : eval 'use IO::Socket::SSL 1.94 (); 1'; | |||
| use constant DEFAULT => eval { IO::Socket::SSL->VERSION("1.965") } | |||
There was a problem hiding this comment.
We use single quotes whenever possible.
There was a problem hiding this comment.
right, i actually tend to that too, don't know why i used double quotes there
With versions greater than 1.965 of IO::Socket::SSL no CA is specified with \undef, while with older versions we still need to pass ''
kraih
approved these changes
Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
since IO::Socket::SSL >= 1.965
\undefmeans no CA, that is specificed as''in older versionsMotivation
Otherwise we observe errors like:
References
https://progress.opensuse.org/issues/23934#change-62720