use class_to_path to load modules in Mojo::Base #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grinnz
force-pushed
the
mojo_base_class_to_path
branch
from
daa029d
to
4a8da70
Compare
Grinnz
commented
Nov 7, 2017
| $file =~ s!::|'!/!g; | ||
| require "$file.pm"; | ||
| elsif ($flags[0] && !$flags[0]->can('new')) { | ||
| require(Mojo::Util::class_to_path($flags[0])); |
There was a problem hiding this comment.
Parentheses are needed for Mojo::Util::class_to_path to avoid circular require issues. Parentheses are needed for require to avoid weird syntax errors possibly related to indirect object syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With circular require issues solved, class_to_path can be reused in Mojo::Base for loading modules.
Motivation
Code reuse
References