multipart request sometimes causes infinit loop

[jamadam]

I found multipart request sometimes causes infinit loop.
This is very rare case and not occurs on proper way to use of Mojolicious.
You can reproduce it by parsing request twice with hash or hash reference for argument.
Parsing request twice may not be a good idea but avoiding the infinit loop makes the class more reliable.

I encountered this when I was working on a plugin which reconstract the request with modified %ENV inside on_process.

https://github.com/jamadam/Mojolicious-Plugin-PlackMiddleware/blob/master/lib/Mojolicious/Plugin/PlackMiddleware.pm#L128

[kraih]

Yes, parsing multiple times is a very bad idea and i'm sure it will cause many more problems.
This does not seem like a real solution though.

[jamadam]

Ok. I'll look for another workround. Thank you.

[kraih]

I'm sure you'll find a lot of helpful tests in "t/mojo/message.t", there are many special cases that would have to be tested for reparsing too.

[jamadam]

Thanks. I'll look into that.