Removes cloudflare dependency from debug.html.ep #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraih
reviewed
Jun 18, 2023
marcusramberg
previously approved these changes
Jun 18, 2023
Replaces the font awesome icons with svg from: - https://icones.js.org/collection/fa6-regular - https://icones.js.org/collection/fa-brands
hernan604
force-pushed
the
remove_cloudflare_fontawesome_dep_from_debug_html
branch
from
1833e99
to
aabbf57
Compare
mergify
bot
dismissed
marcusramberg’s stale review
Pull request has been modified.
|
Squashed |
|
Would be nice if you fixed the same issue in mojo.js too. |
kraih
requested review from
a team,
kraih,
jhthorsen,
christopherraa and
marcusramberg
Grinnz
approved these changes
Jun 18, 2023
|
It appears the mouseover effect no longer works after the patch. |
|
Sent a fix in another PR #2079 |
|
Note that this PR breaks the license of the contributed 3rd party code, i have fixed this after the fact. Please be more careful in the future and respect license agreements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes cloudflare dependency from debug.html.ep and replaces the font awesome icons with svg from:
https://icones.js.org/collection/fa6-regular
https://icones.js.org/collection/fa-brands
Motivation
User complains that debug.html.ep hangs when he is offline and the issue seems to be because of external dependency on icons hosted on cloudflare CDN
References
Jun/18/2023 - $user: it might be an improvement to remove the line referencing cloudflare in debug.html.ep
Jun/18/2023 - kraih: then there's no font awesome, feel free to propose an alternative way to load it that doesn't make it hang though