Fix for handling changes in File::Find 1.41 on win #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraih
requested review from
a team,
marcusramberg,
kraih,
jberger and
Grinnz
jhthorsen
reviewed
Sep 22, 2023
|
There are two consequences of this bug on the returned collection:
When I considered a test for the two things above it felt redundant as this is already tested in the tests that fail. I'm open to suggestion though if you have a better idea for a test for this? |
kraih
reviewed
Sep 22, 2023
lib/Mojo/File.pm
Outdated
| @@ -63,17 +63,18 @@ sub list_tree { | |||
|
|
|||
| # The File::Find documentation lies, this is needed for CIFS | |||
| local $File::Find::dont_use_nlink = 1 if $options->{dont_use_nlink}; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Not sure how that whitespace crept in - now removed
|
Squash your commits. |
In a relatively recent update to File::Find (which was included in the Perl 5.38 release) a change was made to how the windows directory separator ('\') is handled and to convert this within File::Find to '/' to make it consistent:
Perl/perl5@414f14d
This then causes tests to fail in Mojo::File with Perl 5.38 on Windows.
mikemagowan
force-pushed
the
mojo_file_win_fix
branch
from
d10b608
to
fff4b72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a relatively recent update to File::Find v1.41 (which was included in the Perl 5.38 release) a change was made to how the windows directory separator (backslash) is handled and is now converted within File::Find to a forward slash to make it consistent. This was done in the below commit:
Perl/perl5@414f14d
This now causes several tests to fail in Mojo::File with Perl 5.38 on Windows.
Motivation
Mojolicious will not past tests on Windows with Perl 5.38.
References
#2105