Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSON and Dumper in ojo.pm #339

Closed
wants to merge 1 commit into from
Closed

Support JSON and Dumper in ojo.pm #339

wants to merge 1 commit into from

Conversation

sharifulin
Copy link
Contributor

Hi!

Would you like to confirm this pull request?

@kraih
Copy link
Member

kraih commented Jun 19, 2012

I don't like the way both are implemented, the API doesn't feel right.

@sharifulin
Copy link
Contributor Author

Do you have any idea to implement both functions another way?

@kraih
Copy link
Member

kraih commented Jun 19, 2012

I think my main problem is with the "j" function, it's just ugly and i have no idea how to do it better.

@kraih kraih closed this in abf911b Jun 19, 2012
@kraih
Copy link
Member

kraih commented Jun 19, 2012

The "r" function however is actually something i can see myself use a lot too. :)

@sharifulin
Copy link
Contributor Author

Sebastian, "j" is good name for JSON, let's implement it "as is", we can reimplement it always :-)
Mojo::DOM exists, but Mojo::JSON no...

@marcusramberg
Copy link
Member

I agree it's ugly. Maybe we could just implement it like Mojo::DOM and return a new one every time?

@kraih
Copy link
Member

kraih commented Jun 19, 2012

How would that work? Got any examples?

@kraih kraih reopened this Jun 19, 2012
@kraih kraih closed this in e3f2cbf Jun 19, 2012
@kraih
Copy link
Member

kraih commented Jun 19, 2012

That should be much more pleasant to use in oneliners. http://mojolicio.us/perldoc/ojo#j

@sharifulin
Copy link
Contributor Author

Good.

On Tue, Jun 19, 2012 at 4:29 PM, Sebastian Riedel <
reply@reply.github.com

wrote:

That should be much more pleasant to use in oneliners.
http://mojolicio.us/perldoc/ojo#j


Reply to this email directly or view it on GitHub:
#339 (comment)

ó Õ×ÁÖÅÎÉÅÍ,
áÎÁÔÏÌÉÊ ûÁÒÉÆÕÌÉÎ.

@memowe
Copy link
Contributor

memowe commented Jun 19, 2012

Very cool! \oF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants