finer SSL_verify_mode control #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a server whose certificate is new enough that I have to also include the CA file with it:
However, when I add the 'ca' parameter, this enables client/peer certificate verification, which I don't want to enforce. My commit adds another URL parameter called 'verify' that accepts a SSL_verify_mode hex flag; if no verify parameter is present, the default of 0x03 is used. The new syntax works like this:
Thanks for Mojolicious! (even if you don't pull this change)—it has made my life dramatically more fun :)
Scott