Issue with huge file uploads on 32-bit Perl #445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to depoy a Mojolicious application on a Perl 5.10.1 w/ 32 bit on an Open Solaris system.
That application offers a file upload.
By trying to upload a file > 2G (and smaller than 4G) with multipart/form-data, the application tries to load everything into RAM - without considerung $MOJO_MAX_MESSAGE_SIZE.
The reason seems to be an overflow of a signed 32-bit decimal in substr(). A simple test:
On a 64-bit system the result is '3' of course.
Also interesting is the double-overflow btw:
The additional tests in t/mojo/content.t are failing without the changes in lib/Mojo/Content.pm .