Mojo::JSON encoding and decoding of binary data "\a\b" #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no test for the encoding to JSON of "\a\b" or the decoding of the corresponding JSON data. This change adds such tests.
Mojo::JSON has incorrect value associated with the escaped special character 'b'. This change corrects the value, from '\x07' to '\x08'.
kraih
added a commit
that referenced
this pull request
Nov 8, 2013
Mojo::JSON encoding and decoding of binary data "\a\b"
|
Thanks, applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sebastian,
Mojo::JSON.pm appears to have incorrect mapping of the escape character "\b" to "\x07" instead of "\x08". As a result, in my use, binary data encoded by Mojo::JSON arrives at the client subtly corrupted.
I have added tests for the encoding of "\a\b" and decoding of the corresponding JSON data, and changed Mojo::JSON.pm to handle these characters correctly, as I understand the situation.
Regards,
Ian