use true/false functions instead of variables to allow monkey-patched Mojo::JSON #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the performance cost? |
kraih
added a commit
that referenced
this pull request
Mar 11, 2015
use true/false functions instead of variables to allow monkey-patched Mojo::JSON
|
There is a cost, but it's not that bad. |
|
Any cost is certainly mitigated by being able to use XS-based JSON encoders anyway ;) |
|
And reverted, since modules like |
|
The other day I was considering to monkey patch Mojo::JSON. I think it would be very beneficial to make Mojo::JSON to use internally JSON::XS if installed?.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes _decode_value() to use the true and false functions in case they have been monkey patched to return different boolean objects, e.g. by Mojo::JSON::MaybeXS.